Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/table): add 'center' to justify input available types in text-column #23920

Closed
velWiktoria opened this issue Nov 8, 2021 · 1 comment · Fixed by #24133
Closed

feat(cdk/table): add 'center' to justify input available types in text-column #23920

velWiktoria opened this issue Nov 8, 2021 · 1 comment · Fixed by #24133
Assignees
@crisbeto
Labels
area: cdk/table feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@velWiktoria
Copy link

Feature Description

In text-column component user can set justify property to 'start' and 'end'. However as the input is passed to text-align, it should also accept 'center' to allow users to align text in the center of the column. I have tried to make a pull request, however it would make changes to the API, so I was not able to go further with it.

Use Case

User wants to easily center the text in simple text column with the provided justify input
@velWiktoria velWiktoria added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Nov 8, 2021
@crisbeto crisbeto added area: cdk/table P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Nov 17, 2021
@crisbeto crisbeto self-assigned this Dec 24, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 24, 2021
@crisbeto
feat(cdk/table): allow text column to be centered
2a4638f 
Allows for the text inside a text column to be centered.

Fixes angular#23920.
@crisbeto crisbeto mentioned this issue Dec 24, 2021
Merged
andrewseguin pushed a commit that referenced this issue Mar 3, 2022
@crisbeto
feat(cdk/table): allow text column to be centered (#24133)
508b7ac 
Allows for the text inside a text column to be centered.

Fixes #23920.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 3, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
@crisbeto @forsti0506
feat(cdk/table): allow text column to be centered (angular#24133)
9f9b43c 
Allows for the text inside a text column to be centered.

Fixes angular#23920.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: cdk/table feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cdk/table): allow text column to be centered crisbeto/material2
2 participants
@crisbeto @velWiktoria