Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for undefined label in _animateAndLockLabel() #18663

Closed
gentunian opened this issue Feb 29, 2020 · 1 comment · Fixed by #18666, lingounet/testage#15, lingounet/testage#19, hrueger/AGLight#117 or michael-vasyliv/ngx-virtual-swiper#13
Closed

check for undefined label in _animateAndLockLabel() #18663

gentunian opened this issue Feb 29, 2020 · 1 comment · Fixed by #18666, lingounet/testage#15, lingounet/testage#19, hrueger/AGLight#117 or michael-vasyliv/ngx-virtual-swiper#13
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@gentunian
Copy link

gentunian commented Feb 29, 2020 •
edited
Loading

this._label should be checked for undefined in form-field.ts _animateAndLockLabel()

Reproduction

Go to: https://components-issue-gyskyq.stackblitz.io/

Steps to reproduce:

  1. Toggle the slider
  2. Check for console error: Error: Cannot read property 'nativeElement' of undefined

Expected Behavior

No errors in console.

Actual Behavior

Errors are throw in console: Error: Cannot read property 'nativeElement' of undefined

Environment

stackblitz example attached.
@crisbeto crisbeto self-assigned this Mar 1, 2020
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Mar 1, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 1, 2020
@crisbeto
fix(form-field): error when trying to lock label into position too early
72debcd 
Fixes an error that is thrown by the form field's `_animateAndLockLabel` if it's called before `ngAfterViewInit`. This can happen if an autocomplete receives focus too early.

Fixes angular#18663.
@crisbeto crisbeto mentioned this issue Mar 1, 2020
Merged
andrewseguin pushed a commit that referenced this issue Mar 12, 2020
@crisbeto
fix(form-field): error when trying to lock label into position too ea…
eb92de8 
…rly (#18666)

Fixes an error that is thrown by the form field's `_animateAndLockLabel` if it's called before `ngAfterViewInit`. This can happen if an autocomplete receives focus too early.

Fixes #18663.
andrewseguin pushed a commit that referenced this issue Mar 12, 2020
@crisbeto @andrewseguin
fix(form-field): error when trying to lock label into position too ea…
6fd3e6c 
…rly (#18666)

Fixes an error that is thrown by the form field's `_animateAndLockLabel` if it's called before `ngAfterViewInit`. This can happen if an autocomplete receives focus too early.

Fixes #18663.

(cherry picked from commit eb92de8)
@snyk-bot snyk-bot mentioned this issue Mar 19, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Mar 28, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 8, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(form-field): error when trying to lock label into position too early crisbeto/material2
[Snyk] Upgrade: @angular/cdk, @angular/material, @angular/material-moment-adapter lingounet/testage
[Snyk] Upgrade: @angular/cdk, @angular/material, @angular/material-moment-adapter lingounet/testage
[Snyk] Upgrade: @angular/cdk, @angular/material hrueger/AGLight
[Snyk] Upgrade @angular/cdk from 9.1.2 to 9.1.3 michael-vasyliv/ngx-virtual-swiper
[Snyk] Upgrade: @angular/cdk, @angular/material Jujulego/tour-of-heroes
[Snyk] Upgrade @angular/cdk from 9.1.3 to 9.2.0 michael-vasyliv/ngx-virtual-swiper
[Snyk] Upgrade: @angular/cdk, @angular/material vanjo9800/vankata_tech
[Snyk] Upgrade: @angular/cdk, @angular/material Jujulego/tour-of-heroes
[Snyk] Upgrade: @angular/cdk, @angular/material sagar-webdeveloper/posts-application
2 participants
@gentunian @crisbeto