Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(button): move harness out of experimental #17098

Merged
merged 1 commit into from
Sep 16, 2019
Merged

feat(button): move harness out of experimental #17098

merged 1 commit into from
Sep 16, 2019

Conversation

mmalerba
Copy link
Contributor

based on top of #17080

CARETAKER NOTE: merge-safe, but may require BUILD file updates in g3

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround blocked This issue is blocked by some external factor, such as a prerequisite PR pr: merge safe merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release labels Sep 16, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Sep 16, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 16, 2019
@mmalerba mmalerba removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Sep 16, 2019
jelbourn
jelbourn approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 16, 2019
@jelbourn jelbourn merged commit 3dc33f1 into angular:master Sep 16, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @jelbourn @googlebot