fix(ng-update): do not always use double quotes for generated imports #16131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when someone uses single quote import declarations in their project and the `ng update` migration for Material runs, the Material imports are rewritten into multiple imports referring to individual secondary entry-points, but the actual existing quote style is ignored. This means that the linter can sometimes complain after the migration has been performed. Ideally we'd run the tslint fix task after the migration ran in order to fix all lint rule failures which are specific to the given project, but this is not a best-practice yet and we need to decide on the CLI-side whether the CLI should automatically run the fixers after generator/migration schematics ran. See: angular/angular-cli#14532 Unfortunately we can't do the same thing for the whitespace within the `NamedImports` declaration because the whitespace for object literal expressions is hard-coded. See: https://github.com/microsoft/TypeScript/blob/6a559e37ee0d660fcc94f086a34370e79e94b17a/src/compiler/emitter.ts#L3796-L3797 (`emitObjectLiteralExpression` does not allow configuring the format flags) Fixes angular#14532
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…angular#16131) Currently when someone uses single quote import declarations in their project and the `ng update` migration for Material runs, the Material imports are rewritten into multiple imports referring to individual secondary entry-points, but the actual existing quote style is ignored. This means that the linter can sometimes complain after the migration has been performed. Ideally we'd run the tslint fix task after the migration ran in order to fix all lint rule failures which are specific to the given project, but this is not a best-practice yet and we need to decide on the CLI-side whether the CLI should automatically run the fixers after generator/migration schematics ran. See: angular/angular-cli#14532 Unfortunately we can't do the same thing for the whitespace within the `NamedImports` declaration because the whitespace for object literal expressions is hard-coded. See: https://github.com/microsoft/TypeScript/blob/6a559e37ee0d660fcc94f086a34370e79e94b17a/src/compiler/emitter.ts#L3796-L3797 (`emitObjectLiteralExpression` does not allow configuring the format flags) Fixes angular#14532
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when someone uses single quote import declarations in
their project and the
ng updatemigration for Material runs, theMaterial imports are rewritten into multiple imports referring to
individual secondary entry-points, but the actual existing quote
style is ignored. This means that the linter can sometimes complain
after the migration has been performed.
Ideally we'd run the tslint fix task after the migration ran in order to
fix all lint rule failures which are specific to the given project, but this
is not a best-practice yet and we need to decide on the CLI-side whether
the CLI should automatically run the fixers after generator/migration
schematics ran. See: angular/angular-cli#14532
Unfortunately we can't do the same thing for the whitespace within
the
NamedImportsdeclaration because the whitespace for objectliteral expressions is hard-coded. See:
https://github.com/microsoft/TypeScript/blob/6a559e37ee0d660fcc94f086a34370e79e94b17a/src/compiler/emitter.ts#L3796-L3797
(
emitObjectLiteralExpressiondoes not allow configuring the format flags)