Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$cdk-z-index-overlay-* scss variables should have !default #15467

Closed
Totati opened this issue Mar 13, 2019 · 1 comment · Fixed by #15507
Closed

$cdk-z-index-overlay-* scss variables should have !default #15467

Totati opened this issue Mar 13, 2019 · 1 comment · Fixed by #15507
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Totati
Copy link
Contributor

Totati commented Mar 13, 2019

What is the expected behavior?

Being able to configure the $cdk-z-index-overlay, $cdk-z-index-overlay-container, and $cdk-z-index-overlay-backdrop values.

What is the current behavior?

I have to override the values with css selectors.

What are the steps to reproduce?

$cdk-z-index-overlay-container: 1080;
$cdk-z-index-overlay: 1080;
$cdk-z-index-overlay-backdrop: 1080;
@import '~node_modules/@angular/cdk/overlay';
@include cdk-overlay();

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

"@angular/animations": "~7.2.0",
"@angular/cdk": "^7.3.3",
"@angular/common": "~7.2.0",
"@angular/compiler": "~7.2.0",
"@angular/core": "~7.2.0",
"@angular/forms": "~7.2.0",
"@angular/platform-browser": "~7.2.0",
"@angular/platform-browser-dynamic": "~7.2.0",
"@angular/router": "~7.2.0",
"@angular/material": "^7.3.3",
"@ngx-translate/core": "~11.0.1",
"bootstrap": "4.2.1",
"core-js": "^2.5.4",
"ngx-bootstrap": "^3.1.4",
"rxjs": "~6.3.3",
"tslib": "^1.9.0",
"zone.js": "~0.8.26"

@crisbeto crisbeto self-assigned this Mar 14, 2019
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Mar 17, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 17, 2019
Marks the overlay-related Sass variables as `default` so that they can be overwritten.

Fixes angular#15467.
jelbourn pushed a commit that referenced this issue Mar 26, 2019
Marks the overlay-related Sass variables as `default` so that they can be overwritten.

Fixes #15467.
jelbourn pushed a commit that referenced this issue May 13, 2019
Marks the overlay-related Sass variables as `default` so that they can be overwritten.

Fixes #15467.
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this issue Jun 21, 2019
…#15507)

Marks the overlay-related Sass variables as `default` so that they can be overwritten.

Fixes angular#15467.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants