Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matTooltip does not reliably disappear when closing matSelect with ESC #14278

Closed
chadfranzen opened this issue Nov 26, 2018 · 1 comment · Fixed by #14434
Closed

matTooltip does not reliably disappear when closing matSelect with ESC #14278

chadfranzen opened this issue Nov 26, 2018 · 1 comment · Fixed by #14434
Assignees
@crisbeto
Labels
area: material/select area: material/tooltip P4 A relatively minor issue that is not relevant to core functions

Comments

@chadfranzen
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

If a mat-option inside a mat-select panel has a matTooltip applied to it, and the tooltip is being shown, closing the mat-select should cause that tooltip to disappear.

What is the current behavior?

If the select panel is closed using the ESC key, and the mouse does not move during closing, the tooltip can remain onscreen until the user clicks elsewhere.

What are the steps to reproduce?

StackBlitz: https://stackblitz.com/edit/angular-1paubu

  1. Open the select panel and select one of the options
  2. Open the panel again, hover over an option so that the tooltip appears
  3. Press the ESC key to close the panel. Don't move the mouse while it is closing
  4. The tooltip should still be visible after the panel has closed. It will remain visible until you click somewhere else.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular Material 7.1.0
@josephperrott josephperrott self-assigned this Nov 26, 2018
@josephperrott josephperrott added the P4 A relatively minor issue that is not relevant to core functions label Nov 26, 2018
@crisbeto crisbeto added the has pr label Dec 9, 2018
@crisbeto crisbeto self-assigned this Dec 9, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 9, 2018
@crisbeto
fix(tooltip): not closing if escape is pressed while trigger isn't fo…
642483b 
…cused

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire if the trigger doesn't have focus. This could happen when a tooltip was opened by hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to handle the events instead.

Fixes angular#14278.
@crisbeto crisbeto mentioned this issue Dec 9, 2018
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 3, 2019
@crisbeto
fix(tooltip): not closing if escape is pressed while trigger isn't fo…
a34feed 
…cused

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire if the trigger doesn't have focus. This could happen when a tooltip was opened by hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to handle the events instead.

Fixes angular#14278.
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 21, 2019
@crisbeto
fix(tooltip): not closing if escape is pressed while trigger isn't fo…
b50ab13 
…cused

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire if the trigger doesn't have focus. This could happen when a tooltip was opened by hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to handle the events instead.

Fixes angular#14278.
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 5, 2019
@crisbeto
fix(tooltip): not closing if escape is pressed while trigger isn't fo…
cd7ec58 
…cused

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire if the trigger doesn't have focus. This could happen when a tooltip was opened by hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to handle the events instead.

Fixes angular#14278.
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 12, 2019
@crisbeto
fix(tooltip): not closing if escape is pressed while trigger isn't fo…
bca83bb 
…cused

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire if the trigger doesn't have focus. This could happen when a tooltip was opened by hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to handle the events instead.

Fixes angular#14278.
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 13, 2019
@crisbeto
fix(tooltip): not closing if escape is pressed while trigger isn't fo…
66a4c3e 
…cused

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire if the trigger doesn't have focus. This could happen when a tooltip was opened by hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to handle the events instead.

Fixes angular#14278.
@josephperrott josephperrott removed their assignment May 28, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 11, 2020
@crisbeto
fix(tooltip): not closing if escape is pressed while trigger isn't fo…
f9953d7 
…cused

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire if the trigger doesn't have focus. This could happen when a tooltip was opened by hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to handle the events instead.

Fixes angular#14278.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 23, 2020
@crisbeto
fix(material/tooltip): not closing if escape is pressed while trigger…
1489a3b 
… isn't focused

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire
if the trigger doesn't have focus. This could happen when a tooltip was opened by
hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to
handle the events instead.

Fixes angular#14278.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 22, 2021
@crisbeto
fix(material/tooltip): not closing if escape is pressed while trigger…
06dc26f 
… isn't focused

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire
if the trigger doesn't have focus. This could happen when a tooltip was opened by
hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to
handle the events instead.

Fixes angular#14278.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 14, 2021
@crisbeto
fix(material/tooltip): not closing if escape is pressed while trigger…
444c086 
… isn't focused

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire
if the trigger doesn't have focus. This could happen when a tooltip was opened by
hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to
handle the events instead.

Fixes angular#14278.
andrewseguin pushed a commit that referenced this issue Jan 13, 2022
@crisbeto
fix(material/tooltip): not closing if escape is pressed while trigger…
08aed71 
… isn't focused (#14434)

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire
if the trigger doesn't have focus. This could happen when a tooltip was opened by
hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to
handle the events instead.

Fixes #14278.
andrewseguin pushed a commit that referenced this issue Jan 13, 2022
@crisbeto @andrewseguin
fix(material/tooltip): not closing if escape is pressed while trigger…
e01e579 
… isn't focused (#14434)

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire
if the trigger doesn't have focus. This could happen when a tooltip was opened by
hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to
handle the events instead.

Fixes #14278.

(cherry picked from commit 08aed71)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 13, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
@crisbeto @forsti0506
fix(material/tooltip): not closing if escape is pressed while trigger…
47c5b4c 
… isn't focused (angular#14434)

Currently the tooltip's `keydown` handler is on the trigger, which means that it won't fire
if the trigger doesn't have focus. This could happen when a tooltip was opened by
hovering over the trigger. These changes use the `OverlayKeyboardDispatcher` to
handle the events instead.

Fixes angular#14278.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/select area: material/tooltip P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
4 participants
@crisbeto @chadfranzen @josephperrott @andrewseguin