Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): support FIREBASE_TOKEN for ng deploy #2327

Merged
merged 8 commits into from
Nov 11, 2020

Conversation

IKatsuba
Copy link
Contributor

Checklist

Description

Code sample

@IKatsuba
Copy link
Contributor Author

IKatsuba commented Mar 3, 2020

Any updates?

@IKatsuba
Copy link
Contributor Author

@jamesdaniels hello! I really need this feature. Can you give comments on it?

@jamesdaniels jamesdaniels added this to the 6.0.0 milestone Mar 27, 2020
@jamesdaniels
Copy link
Member

We'll get this in shortly, thanks for the contribution.

…-env

# Conflicts:
#	src/schematics/deploy/actions.jasmine.ts
#	src/schematics/deploy/actions.ts
#	src/schematics/deploy/builder.ts
@wajeehmisbahkhan
Copy link

Please provide updates on this or at least an alternative on how to use the firebase token in a CI environment. I tried deploying in Github Actions with

env:
  FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}

And I get:
Cannot run login in non-interactive mode. See login:ci to generate a token for use in non-interactive environments.

How do I set the environment variable so that it doesn't require a login?

@IKatsuba
Copy link
Contributor Author

IKatsuba commented Jun 8, 2020

@wajeehmisbahkhan I tried to update the request, but the team never looked at it. Maybe @jamesdaniels have a different plan. Now I have no time to support this PR.

@jamesdaniels jamesdaniels modified the milestones: 6.0.0, 6.1 Jun 23, 2020
@jamesdaniels
Copy link
Member

I can take this to the finish line before I cut 6.1, thanks @IKatsuba

@IKatsuba
Copy link
Contributor Author

@wajeehmisbahkhan you can try this package @ng-builders/firebase

@jamesdaniels jamesdaniels merged commit dd92869 into angular:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants