Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng deploy builder does not work well in CI #2138

Closed
FrozenPandaz opened this issue Aug 2, 2019 · 3 comments
Closed

ng deploy builder does not work well in CI #2138

FrozenPandaz opened this issue Aug 2, 2019 · 3 comments

Comments

@FrozenPandaz
Copy link
Contributor

Version info

Angular: 8.2.0-next.2

Firebase: 6.3.4

**AngularFire:**5.2.1

**Other (e.g. Ionic/Cordova, Node, browser, operating system):**CircleCI

How to reproduce these conditions

Try and deploy via CircleCI.

Expected behavior

interactive and token should probably be options for the ng deploy option. Otherwise, it is difficult to deploy via CI environments like CircleCI.

Actual behavior

interactive and token cannot be passed through the builder.

I tried using the environment variable $FIREBASE_TOKEN which I think (not sure) logs me in correctly but prompts for analytics. I guess adding only the interactive flag would bypass this but I think token is the recommended method of passing the FIREBASE_TOKEN.

@jamesdaniels
Copy link
Member

Good point, thanks for pointing out. I'll try to get this together in a future release.

@mcarey1590
Copy link

it would be nice to have a way to disable building as well. Our CI builds and creates an artifact to deploy in another stage.

@jamesdaniels
Copy link
Member

environment variable is respected starting in 6.1.0-rc.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants