Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngcc - support the new spread helper in TS 4.2 #40394

Closed
petebacondarwin opened this issue Jan 11, 2021 · 1 comment
Closed

ngcc - support the new spread helper in TS 4.2 #40394

petebacondarwin opened this issue Jan 11, 2021 · 1 comment
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR type: bug/fix
Milestone
Backlog

Comments

@petebacondarwin
Copy link
Contributor

See microsoft/TypeScript#41523
@petebacondarwin petebacondarwin added comp: ngcc P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: blocked type: bug/fix labels Jan 11, 2021
@ngbot ngbot bot modified the milestone: Backlog Jan 11, 2021
JoostK added a commit to JoostK/angular that referenced this issue Mar 13, 2021
@JoostK
feat(ngcc): support __spreadArray helper as used by TypeScript 4.2
245a7f3 
In TypeScript 4.2 the `__spread` and `__spreadArrays` helpers were both
replaced by the new helper function `__spreadArray` in
microsoft/TypeScript#41523. These helpers may be used in downleveled
JavaScript bundles that ngcc has to process, so ngcc has the ability to
statically detect these helpers and provide evaluation logic for them.
Because Angular is adopting support for TypeScript 4.2 it becomes
possible for libraries to be compiled by TypeScript 4.2 and thus ngcc
has to add support for the `__spreadArray` helper. The deprecated
`__spread` and `__spreadArrays` helpers are not affected by this change.

Closes angular#40394
@JoostK JoostK mentioned this issue Mar 13, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

feat(ngcc): support __spreadArray helper as used by TypeScript 4.2 JoostK/angular
2 participants
@petebacondarwin @JoostK