fix($routeProvider): fix #1501 wrong mapping of $routeParams #1692
Conversation
|
I've changed one line commited and rebased the two commits in 7feece8 |
|
@gonzaloruizdevilla just add the commit to this very same branch (issue1501) and push it to your repository |
|
@gonzaloruizdevilla I looked at 7feece8 and ideally you should reset your issue1501 branch to 7feece8 and then force-push to your github repo. that will update this pull request. |
|
I reviewed 7feece8 and except for small formatting issue and a better subject in the commit message it looks great. |
Routes like '/bar/foovalue/barvalue' matching '/bar/:foo/:bar'
now are well mapped in $routeParams to:
{bar:'barvalue', foo:'foovalue'}
Closes: angular#1501
Signed-off-by: Gonzalo Ruiz de Villa <[email protected]>
|
@IgorMinar Thank you for your instructions. I've changed the commit message and I've addressed the formatting issue. |
|
landed as 30a9da5 thanks! If you haven't received our t-shirt yet please fill out http://goo.gl/075Sj |
Routes like '/bar/foovalue/barvalue' matching '/bar/:foo/:bar'
now are well mapped in $routeParams to:
{bar:'barvalue', foo:'foovalue'}
Closes: #1501
Signed-off-by: Gonzalo Ruiz de Villa [email protected]