Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

StaticMetadataExtractor does not map members to all annotations #904

Closed
blois opened this issue Apr 15, 2014 · 2 comments
Closed

StaticMetadataExtractor does not map members to all annotations #904

blois opened this issue Apr 15, 2014 · 2 comments
Milestone

Comments

@blois
Copy link
Contributor

blois commented Apr 15, 2014

The dynamic metadata extractor maps member annotations to all AbstractNgAnnotations while the StaticMetadataExtractor only does this to the first one. The static extractor should do it to all annotations.

@blois blois self-assigned this Apr 15, 2014
@vicb
Copy link
Contributor

vicb commented Apr 15, 2014

I'm working on the static extractor as part of #861 if nobody handles this one, I can take a look while I'm at it ?

@blois
Copy link
Contributor Author

blois commented Apr 15, 2014

Sure, it should be straight-forward- _foldMemberAnnotations finds all annotations which should have the member annotations folded in but then only does it on the first one- https://github.com/angular/angular.dart/blob/master/lib/tools/transformer/metadata_extractor.dart#L340

Let me know if you have any questions on it.

vicb added a commit to vicb/angular.dart that referenced this issue Apr 15, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Apr 16, 2014
@mhevery mhevery added this to the 0.10.0 milestone Apr 16, 2014
@blois blois assigned vicb and unassigned blois Apr 16, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Apr 17, 2014
@mhevery mhevery modified the milestones: 0.12.0, 0.10.0 Apr 17, 2014
@vicb vicb closed this as completed in 9622318 Apr 18, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Apr 21, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Apr 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants