This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feat(components): add support for multiple insertion points #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| _replaceContentElementWithScriptTags() { | ||
| _beginScript = new dom.ScriptElement() | ||
| ..setAttribute("content-tag-id", _content.id) |
There was a problem hiding this comment.
create a static one and clone it, Should be faster than creating it all the time.
|
@vsavkin could you please add some comment about what the PR is supposed to enabled in the PR header ? |
| @@ -332,10 +338,18 @@ class DirectiveInjector implements DirectiveBinder { | |||
|
|
|||
| NgElement get ngElement { | |||
| if (_ngElement == null) { | |||
| _ngElement = new NgElement(_node, scope, _animate); | |||
| _ngElement = new NgElement(_node, scope, _animate, getByKey(DESTINATION_LIGHT_DOM_KEY)); | |||
There was a problem hiding this comment.
instead of getByKey, can't you just do parent.lightDOM? Should be faster.
vsavkin
changed the title
vsavkin
changed the title
|
Few minor comments, but otherwise this looks good to me. |
Closed
|
Test and rebase before we can merge. |
vsavkin
force-pushed
the
shadowless_components_distributions
branch
2 times, most recently
from
048f74c to
ffdab53
Compare
|
@jbdeboer I've rebased the branch |
vsavkin
force-pushed
the
shadowless_components_distributions
branch
from
ffdab53 to
bef63ef
Compare
Some directives require access to the current view. Add the view field to the DirectiveInjector class, so it can be injected.
vsavkin
force-pushed
the
shadowless_components_distributions
branch
2 times, most recently
from
f155893 to
b3b6db7
Compare
…cluding components Add implementations of the light dom and the content tag to support multiple insertion points for transcluding components.
vsavkin
force-pushed
the
shadowless_components_distributions
branch
from
b3b6db7 to
e3689be
Compare
vsavkin
added a commit
that referenced
this pull request
Aug 26, 2014
…cluding components Add implementations of the light dom and the content tag to support multiple insertion points for transcluding components. Closes #1290
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #1293.
The current implementation of transcluding components is very limited and allows only one insertion point (a wildcard) and does not support redistribution. This PR adds multiple support for multiple insertion points: