feature: add mobile option on ng new #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "short_name": "<%= htmlComponentName %>", | |||
There was a problem hiding this comment.
short_name should still be human readable. If CLI doesn't have something appropriate, just omit it.
|
LGTM pending one comment. |
| const fullAppName = stringUtils.dasherize(options.entity.name) | ||
| .replace(/-(.)/g, (_, l) => ' ' + l.toUpperCase()) | ||
| .replace(/^./, (l) => l.toUpperCase()); | ||
| console.log(options.mobile) |
|
One small nit, but otherwise lgtm |
|
All done. |
hansl
force-pushed
the
mobile
branch
3 times, most recently
from
a06d180 to
de9b1ac
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #596.