bug(help): resolve issue when using --help #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
suggested changes
Dec 12, 2016
| args[0] = 'help'; | ||
| } else { | ||
| args.shift(); | ||
| args.push('--help'); |
There was a problem hiding this comment.
Yes, --help is an option, not a command. So remove it from the start of the array and push it to the end.
There was a problem hiding this comment.
Nevermind, I was reading unshift. Cheers!
|
e2e test added |
hansl
reviewed
Dec 13, 2016
| return Promise.resolve() | ||
| .then(() => silentNg('--help')) | ||
| .then(() => process.chdir('/')) | ||
| .then(() => silentNg('--help')); |
There was a problem hiding this comment.
Mind trying with a command as well?
hansl
approved these changes
Dec 13, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3195 and #3168