Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): invalid browsers version ranges #22610

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix(@angular-devkit/build-angular): invalid browsers version ranges #22610

merged 1 commit into from
Jan 31, 2022

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jan 31, 2022

This change addresses the Invalid version: "15.2-15.3" range error. We previously only handled version ranges for ios_safari. Now, we handle such versions for all browsers.

Closes #22606

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jan 31, 2022
@alan-agius4 alan-agius4 requested a review from dgp1130 January 31, 2022 11:27
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jan 31, 2022
This change addresses the `Invalid version: "15.2-15.3"` range error. We previously only handled version ranges for `ios_safari`. Now, we handle such versions for all browsers.

Closes #22606
@Shan7anu
Copy link

@dgp1130 Kindly review and merge.

@dgp1130
Copy link
Collaborator

dgp1130 commented Jan 31, 2022

We should probably add a test for the changed behavior as well, but that can come in a separate PR, no need to hold up this one for it.

@dgp1130 dgp1130 merged commit 7f67dbc into angular:master Jan 31, 2022
@alan-agius4 alan-agius4 deleted the invalid-version branch January 31, 2022 17:16
@srinivasreddyp
Copy link

@alan-agius4 Is this fix published and available to run the builds?

@dgp1130
Copy link
Collaborator

dgp1130 commented Jan 31, 2022

@srinivasreddyp, the release is ongoing. We have a large number of packages, multiple versions to publish, and a wide variety of end-to-end tests which take some time to run before we can be confident in a release.

12.2.16 was just published which should contain the fix for users on v12.
The v13 release is still in progress, I'll post an update here when it lands.
Users on v11 shouldn't be affected by this bug.

@srinivasreddyp
Copy link

@srinivasreddyp, the release is ongoing. We have a large number of packages, multiple versions to publish, and a wide variety of end-to-end tests which take some time to run before we can be confident in a release.

12.2.16 was just published which should contain the fix for users on v12. The v13 release is still in progress, I'll post an update here when it lands. Users on v11 shouldn't be affected by this bug.

Thank you for the update, we are on 12.

@dgp1130
Copy link
Collaborator

dgp1130 commented Jan 31, 2022

v13.2.1 just landed and has the same fix.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng build error: Invalid version: "15.2-15.3"
5 participants