This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(timepicker): added wheel event to enable mousewheel on Firefox #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var inputs = element.find('input'); | ||
| var hoursEl = inputs.eq(0), minutesEl = inputs.eq(1); | ||
| var upMouseWheelEvent = wheelThatOtherMouse(-1); | ||
| var downMouseWheelEvent = wheelThatOtherMouse(1); |
There was a problem hiding this comment.
added separate test for the wheel event
the logic of deltaY is opposite of wheelDelta that why the values on up and down are inverted
|
Good job & nice PR @lazychino :-) Just 2 comments/questions on the code. |
|
After check on Chrome 28, Firefox 22, Opera 15, Internet Explorer 9 and Safari(not sure which version is pretty new but forgot to check), the 'wheel' event is only working with Firefox and Internet Explorer. So, my guess is that for the meantime is better to bind both 'mousewheel' and 'wheel' events. |
|
OK @lazychino, that's fine. I think it's good to merge :-) Can you squash the commits to one? |
|
Landed as 8dc92af. Thank you! |
codedogfish
pushed a commit
to codedogfish/angular-ui-bootstrap
that referenced
this pull request
Sep 15, 2015
chore(refactor): split code into multiple files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for this issue669
I added some tests to timepicker.spec.js, and tested on Firefox 22 and Chrome 28
This is my first ever pull request, hope is ok :)