This repository has been archived by the owner on May 29, 2019. It is now read-only.
chore(transition): remove transition module #3459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The `transition` module along with its `$transition` service are no longer available. We're now using `$animate` service for animations and would encourage users to do the same.
|
Should this be in the backlog or in 0.13.0? Given that $transition usage is gone, we might as well just delete it as a breaking change from 0.12 to 0.13. |
|
I was thinking of merging it next major release, say 0.14, as there might be users depending on it and it's not essential to drop it now. Just want to mark it as deprecated first. |
|
Might be worth opening a PR marking it as deprecated in the comments for the service or when users consume the service via |
|
Good idea, will do |
1 task
|
@chrisirhc Weirdly this needs rebasing |
|
Don't worry about this, the rebase would be easy when it comes time to do it. |
|
I merged this in dfa4c97, but looks like I forgot to just close this particular PR :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
The
transitionmodule along with its$transitionservice are no longeravailable. We're now using
$animateservice for animations and wouldencourage users to do the same.