Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Support HTML in tabs title #124

Closed
pkozlowski-opensource opened this issue Feb 6, 2013 · 5 comments
Closed

Support HTML in tabs title #124

pkozlowski-opensource opened this issue Feb 6, 2013 · 5 comments
Labels
type: enhancement

Comments

@pkozlowski-opensource
Copy link
Member

Based on PR #67 (see the discussion in this PR for more details).
Closed
@max-mykhailenko
Copy link

I need it. Waiting for new versions

@ajoslin
Copy link
Contributor

ajoslin commented Feb 10, 2013

Tried to implement it, got annoying test failures. Will try to finish it tomorrow...

@petebacondarwin
Copy link
Member

Hi @ajoslin - I was thinking of implementing it along these lines: http://plnkr.co/edit/qdVrVi6GCofRXjVI8LGw?p=preview

@ajoslin
Copy link
Contributor

ajoslin commented Feb 10, 2013

Fancy! I just had a PaneController which the paneHeading directive called a function on to set some html.

Closed
@petebacondarwin petebacondarwin mentioned this issue Feb 17, 2013
Closed
Closed
@ajoslin ajoslin mentioned this issue Mar 30, 2013
Closed
ajoslin added a commit that referenced this issue Mar 30, 2013
@ajoslin
refactor(tabs): Change syntax, add features
d53855f 
* Tabs transclude to title elements instead of content elements, so the
ordering is always correct (#153)
* Rename `<tabs>` to `<tabset>`, `<pane>` to `<tab>` (#186)
* Add `<tab-heading>` directive, which is a child of a `<tab>`. Allows
HTML in tab headings (#124)
* Add `select` attribute callback when tab is selected (#141)
* Only the active tab's content is actually ever in the DOM
ajoslin added a commit that referenced this issue Mar 31, 2013
@ajoslin
refactor(tabs): Change syntax, add features
5b4ed04 
* Tabs transclude to title elements instead of content elements, so the
ordering is always correct (#153)
* Rename `<tabs>` to `<tabset>`, `<pane>` to `<tab>` (#186)
* Add `<tab-heading>` directive, which is a child of a `<tab>`. Allows
HTML in tab headings (#124)
* Add `select` attribute callback when tab is selected (#141)
* Only the active tab's content is actually ever in the DOM
@thiloplanz thiloplanz mentioned this issue Apr 5, 2013
Closed
ajoslin added a commit that referenced this issue Apr 6, 2013
@ajoslin
refactor(tabs): Change syntax, add features
809b92c 
* Tabs transclude to title elements instead of content elements, so the
ordering is always correct (Closes #153)
* Rename `<tabs>` to `<tabset>`, `<pane>` to `<tab>` (Closes #186)
* Add `<tab-heading>` directive, which is a child of a `<tab>`. Allows
HTML in tab headings (Closes #124)
* Add `select` attribute callback when tab is selected (Closes #141)
* Only the active tab's content is now actually ever in the DOM
ajoslin added a commit that referenced this issue Apr 8, 2013
@ajoslin
feat(tabs): Change directive name, add features
7d01892 
* Rename 'tabs' directive to 'tabset', and 'pane' directive to 'tab'.
 The new syntax is more intuitive; The word pane does not obviously
 represent a subset of a tab group. (Closes #186)
* Add 'tab-heading' directive, which is a child of a 'tab'. Allows
HTML in tab headings. (Closes #124)
* Add option for a 'select' attribute callback when a tab is selected.
 (Closes #141)
* Tabs transclude to title elements instead of content elements. Now the
 ordering of tab titles is always correct. (Closes #153)
* Only the active tab's content is ever present in the DOM. This is
 another plus of transcluding tabs to title elmements, and provies a
 performance increase.

BREAKING CHANGE: The 'tabs' directive has been renamed to 'tabset', and
 the 'pane' directive has been renamed to 'tab'.

    To migrate your code, follow the example below.

    Before:

    <tabs>
      <pane heading="one">
        First Content
      </pane>
      <pane ng-repeat="apple in basket" heading="{{apple.heading}}">
        {{apple.content}}
      </pane>
    </tabs>

    After:

    <tabset>
      <tab heading="one">
        First Content
      </tab>
      <tab ng-repeat="apple in basket" heading="{{apple.heading}}">
        {{apple.content}}
      </tab>
    </tabset>
ajoslin added a commit that referenced this issue Apr 9, 2013
@ajoslin
feat(tabs): Change directive name, add features
8ee76b4 
* Rename 'tabs' directive to 'tabset', and 'pane' directive to 'tab'.
 The new syntax is more intuitive; The word pane does not obviously
 represent a subset of a tab group. (Closes #186)
* Add 'tab-heading' directive, which is a child of a 'tab'. Allows
HTML in tab headings. (Closes #124)
* Add option for a 'select' attribute callback when a tab is selected.
 (Closes #141)
* Tabs transclude to title elements instead of content elements. Now the
 ordering of tab titles is always correct. (Closes #153)
* Only the active tab's content is ever present in the DOM. Provides an
 increase in performance.

BREAKING CHANGE: The 'tabs' directive has been renamed to 'tabset', and
 the 'pane' directive has been renamed to 'tab'.

    To migrate your code, follow the example below.

    Before:

    <tabs>
      <pane heading="one">
        First Content
      </pane>
      <pane ng-repeat="apple in basket" heading="{{apple.heading}}">
        {{apple.content}}
      </pane>
    </tabs>

    After:

    <tabset>
      <tab heading="one">
        First Content
      </tab>
      <tab ng-repeat="apple in basket" heading="{{apple.heading}}">
        {{apple.content}}
      </tab>
    </tabset>
@mlegenhausen
Copy link

+1

ajoslin added a commit that referenced this issue Apr 28, 2013
@ajoslin
feat(tabs): Change directive name, add features
5a0bd33 
* Rename 'tabs' directive to 'tabset', and 'pane' directive to 'tab'.
 The new syntax is more intuitive; The word pane does not obviously
 represent a subset of a tab group. (Closes #186)
* Add 'tab-heading' directive, which is a child of a 'tab'. Allows
HTML in tab headings. (Closes #124)
* Add option for a 'select' attribute callback when a tab is selected.
 (Closes #141)
* Tabs transclude to title elements instead of content elements. Now the
 ordering of tab titles is always correct. (Closes #153)

BREAKING CHANGE: The 'tabs' directive has been renamed to 'tabset', and
 the 'pane' directive has been renamed to 'tab'.

    To migrate your code, follow the example below.

    Before:

    <tabs>
      <pane heading="one">
        First Content
      </pane>
      <pane ng-repeat="apple in basket" heading="{{apple.heading}}">
        {{apple.content}}
      </pane>
    </tabs>

    After:

    <tabset>
      <tab heading="one">
        First Content
      </tab>
      <tab ng-repeat="apple in basket" heading="{{apple.heading}}">
        {{apple.content}}
      </tab>
    </tabset>
Closed
ajoslin added a commit that referenced this issue May 9, 2013
@ajoslin
feat(tabs): Change directive name, add features
bfe20e9 
* Rename 'tabs' directive to 'tabset', and 'pane' directive to 'tab'.
 The new syntax is more intuitive; The word pane does not obviously
 represent a subset of a tab group. (Closes #186)
* Add 'tab-heading' directive, which is a child of a 'tab'. Allows
HTML in tab headings. (Closes #124)
* Add option for a 'select' attribute callback when a tab is selected.
 (Closes #141)
* Tabs transclude to title elements instead of content elements. Now the
 ordering of tab titles is always correct. (Closes #153)

BREAKING CHANGE: The 'tabs' directive has been renamed to 'tabset', and
 the 'pane' directive has been renamed to 'tab'.

    To migrate your code, follow the example below.

    Before:

    <tabs>
      <pane heading="one">
        First Content
      </pane>
      <pane ng-repeat="apple in basket" heading="{{apple.heading}}">
        {{apple.content}}
      </pane>
    </tabs>

    After:

    <tabset>
      <tab heading="one">
        First Content
      </tab>
      <tab ng-repeat="apple in basket" heading="{{apple.heading}}">
        {{apple.content}}
      </tab>
    </tabset>
@ajoslin ajoslin closed this as completed in c532659 May 9, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
5 participants
@petebacondarwin @mlegenhausen @pkozlowski-opensource @max-mykhailenko @ajoslin