Skip to content

fix(native-federation-runtime) runtime crash with non-JS routing (like static HTML apps or SSR apps) #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(native-federation-runtime) runtime crash with non-JS routing (like static HTML apps or SSR apps) #693

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab748ba
Fix: runtime crash with non-JS routing (like static HTML apps or SSR …
Aukevanoost Nov 14, 2024
46161ba
Updated hostRemoteEntry to optional object property for initFederatio…
Aukevanoost Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions libs/native-federation-runtime/src/lib/init-federation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,15 @@ import { appendImportMap } from './utils/add-import-map';
import { FederationInfo } from './model/federation-info';

export async function initFederation(
remotesOrManifestUrl: Record<string, string> | string = {}
remotesOrManifestUrl: Record<string, string> | string = {},
o: {hostRemoteEntry:string|false} = {hostRemoteEntry:'./remoteEntry.json'}
): Promise<ImportMap> {
const remotes =
typeof remotesOrManifestUrl === 'string'
? await loadManifest(remotesOrManifestUrl)
: remotesOrManifestUrl;

const hostInfo = await loadFederationInfo('./remoteEntry.json');
const hostInfo = await loadFederationInfo(o.hostRemoteEntry);
const hostImportMap = await processHostInfo(hostInfo);
const remotesImportMap = await processRemoteInfos(remotes);

Expand Down Expand Up @@ -87,7 +88,9 @@ function createRemoteImportMap(
return { imports, scopes };
}

async function loadFederationInfo(url: string): Promise<FederationInfo> {
async function loadFederationInfo(url: string|false): Promise<FederationInfo> {
if(!url) return {name: "host", exposes: [], shared: []};

const info = (await fetch(url).then((r) => r.json())) as FederationInfo;
return info;
}
Expand Down