Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network ip drift #51

Merged
merged 9 commits into from
May 25, 2021
Merged

Fix network ip drift #51

merged 9 commits into from
May 25, 2021

Conversation

X4mp
Copy link
Contributor

@X4mp X4mp commented May 20, 2021

Description

This MR solves a drift issue introduced by backend changes which lead to an empty IP configuration for networks when polling the VM immediately after creation. To solve this we introduced a retry time-boxed mechanism which fetches the VM until the network config contains IP informations. To avoid additional drift due to link-local or VM internally provisioned IPs the provider now ignores IPs which were not expected by the plan.

Acceptance tests

  • Have you added an acceptance test for the functionality being added? (Already existing tests)
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAnxCloudVirtualServer'
...

Release Note

Release note for CHANGELOG:

* Handle incomplete network informations to avoid drift

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Roland Urbano added 8 commits May 6, 2021 11:17
Signed-off-by: Roland Urbano <[email protected]>
Signed-off-by: Roland Urbano <[email protected]>
Signed-off-by: Roland Urbano <[email protected]>
Signed-off-by: Roland Urbano <[email protected]>
Signed-off-by: Roland Urbano <[email protected]>
@X4mp
Copy link
Contributor Author

X4mp commented May 20, 2021

/ok-to-test sha=9bb9800

@X4mp
Copy link
Contributor Author

X4mp commented May 25, 2021

/ok-to-test sha=d69fbc5

1 similar comment
@X4mp
Copy link
Contributor Author

X4mp commented May 25, 2021

/ok-to-test sha=d69fbc5

@paepke paepke merged commit 37b7c67 into anexia-it:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants