Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Datasource for Tags, CPUPerformanceTypes and VSphere Locations #29

Merged
merged 12 commits into from
Jan 25, 2021
Merged

Add Datasource for Tags, CPUPerformanceTypes and VSphere Locations #29

merged 12 commits into from
Jan 25, 2021

Conversation

stroebitzer
Copy link
Contributor

@stroebitzer stroebitzer commented Jan 20, 2021 •
edited
Loading

Description

Add Datasource for Tags and CPUPerformanceTypes

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAnxCloudTagsDataSource'
$ make testacc TESTARGS='-run=TestAccAnxCloudCPUPerformanceTypesDataSource'
$ make testacc TESTARGS='-run=TestAccAnxCloudVSphereLocationsDataSource'

Release Note

Release note for CHANGELOG:

Add Datasource for Tags

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@stroebitzer stroebitzer changed the title Add Datasource for Tags Add Datasource for Tags and CPUPerformanceTypes Jan 20, 2021
@mfranczy
Copy link
Contributor

Unit tests fail, please run make go-lint, go mod tidy and make docs-lint-fix

@mfranczy
Copy link
Contributor

mfranczy commented Jan 20, 2021 •
edited
Loading

ah ok it fails because v0.3.11 is not released yet, but make docs-lint-fix you can run :)

mfranczy
mfranczy reviewed Jan 22, 2021
View reviewed changes
@mfranczy
Copy link
Contributor

/ok-to-test sha=9e514be

@stroebitzer stroebitzer changed the title Add Datasource for Tags and CPUPerformanceTypes Add Datasource for Tags, CPUPerformanceTypes and VSphere Locations Jan 22, 2021
mfranczy
mfranczy suggested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@mfranczy mfranczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor things.

@mfranczy
Copy link
Contributor

/ok-to-test sha=a3b4aac

@mfranczy
Copy link
Contributor

/ok-to-test sha=54747ce

@mfranczy
Copy link
Contributor

/ok-to-test sha=fd18874

@mfranczy
Copy link
Contributor

/ok-to-test sha=ce11313

@mfranczy mfranczy merged commit 38602d5 into anexia-it:main Jan 25, 2021
mfranczy added a commit to mfranczy/terraform-provider-anxcloud that referenced this pull request Jan 25, 2021
@mfranczy
Merge pull request anexia-it#29 from stroebitzer/main
de34400 
Add Datasource for Tags, CPUPerformanceTypes and VSphere Locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranczy mfranczy mfranczy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stroebitzer @mfranczy