Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rtp h265 #36

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Rtp h265 #36

merged 6 commits into from
Feb 18, 2022

Conversation

rakeshnitb
Copy link
Contributor

No description provided.

@rakeshnitb
Add support for RTSP H265
4b99db9 
Added H265 RTP packet reader and added support for H265
playback through RTSP

Change-Id: Ic0e135768bb92cd3343212c2edd84bae6947320e
@rakeshnitb
Clean up RtpH265Reader
9cb2436
@tonihei
Copy link
Collaborator

tonihei commented Feb 1, 2022

@claincly Could you take a look at this one as well? Thanks!

claincly
claincly requested changes Feb 2, 2022
View reviewed changes
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpH265Reader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpH265Reader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpH265Reader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpH265Reader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpH265Reader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpH265Reader.java Outdated Show resolved Hide resolved
claincly
claincly requested changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@claincly claincly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nits

libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpH265Reader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpH265Reader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpH265Reader.java Outdated Show resolved Hide resolved
@claincly
Copy link
Contributor

Hi Rakesh, this PR is submitted now and should be reflected here once we do a push.

The main difference is we removed the empty method processAggregationPacket and moved the TODO/throw to its call site.

Also, please write some tests for the fragmentation unit processing. It can be as simple as RtpAc3ReaderTest.java.

@icbaker icbaker merged commit f3eb6e1 into androidx:main Feb 18, 2022
icbaker added a commit that referenced this pull request Mar 1, 2022
@icbaker
Merge pull request #36 from ittiam-systems:rtp-h265
e36ea3b 
PiperOrigin-RevId: 429566102
@androidx androidx locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@claincly claincly claincly approved these changes

Assignees

@claincly claincly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rakeshnitb @tonihei @claincly @icbaker