Add VTT voice spans to cues #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icbaker
requested changes
Aug 27, 2024
| public final String speakerName; | ||
|
|
||
| /** The classes associated with the text. It can specify things like "first", "loud", etc. */ | ||
| public final Set<String> classes; |
There was a problem hiding this comment.
aiui these aren't really useful without access to the rest of the styling info. Do you have a use-case/need for these values?
There was a problem hiding this comment.
No I don't have a use for those. Do you want me to remove it?
There was a problem hiding this comment.
Yeah, let's remove it for now, if a use-case comes up later we can re-add it.
| @UnstableApi | ||
| public final class VoiceSpan { | ||
|
|
||
| /** The speaker name. */ |
There was a problem hiding this comment.
the webvtt spec uses the phrase "voice name", so I think we can use that here:
/** The voice name. */
public final String name;
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
icbaker
approved these changes
Aug 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds voice spans available in WebVTT cues. Spans were already parsed but they were never exposed and attached to the output
Spannablecreated byWebvttCueParser. For more info see: #1632