Add support for setting the max seek to previous position on ExoPlayer.Builder and CastPlayer
#1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This method allows customizing the maximum position when using `Player.seekToPrevious()`. This commit also adds two new methods to `TestExoPlayerBuilder`: - `setMaxSeekToPreviousPosition(long)` - `getMaxSeekToPreviousPosition()`
…n the correct value
tonihei
force-pushed
the
add_exoplayer_setMaxSeekToPreviousPosition
branch
2 times, most recently
from
de26ac5 to
48f36c5
Compare
|
Thanks, I'll merge it internally and you may see some additional commit appearing here in the meantime (mostly formatting changes). |
tonihei
force-pushed
the
add_exoplayer_setMaxSeekToPreviousPosition
branch
from
48f36c5 to
cd2250b
Compare
microkatz
pushed a commit
that referenced
this pull request
Jun 18, 2024
…viousPosition PiperOrigin-RevId: 643987403 (cherry picked from commit 67a7b41)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
CastPlayerto provide amaxSeekToPreviousPositionMsargument.MediaControllerImplLegacy.getMaxSeekToPreviousPosition()to return the value fromcontrollerInfo.playerInfo.maxSeekToPreviousPositionMsinstead of 0.TestExoPlayerBuilder.setMaxSeekToPreviousPosition(long).TestExoPlayerBuilder.getMaxSeekToPreviousPosition().Note
This new functionality only allows setting the value at initialisation (for
ExoPlayerandCastPlayer). Let me know if I should also add a dedicated setter on these classes (or onPlayerdirectly).Fixes #1425