This repository has been archived by the owner on May 26, 2022. It is now read-only.
Stop resolver and query when no longer needed #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'm going to investigate this issue. Looks like a bug in my library, service should be stopped after calling callback |
|
Hi @namannik Thanks for your help. I found that it was a bug in library. Check out new version https://github.com/andriydruk/RxDNSSD/releases/tag/0.9.7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
DNSSDBindablein my app, I usedDNSSDActivity.javaas a guide. I found that lots and lots of threads were being created, but never destroyed. This was leading to performance issues and occasionalOutOfMemoryErrorexceptions.I followed your recommendation here regarding stopping
resolveandquerywhen no longer needed, and the issue with numerous threads has been fixed.This pull request updates the example app with this recommendation.