Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add harmony reflect polyfill #6

Closed
wants to merge 1 commit into from
Closed

Conversation

okcoker
Copy link

@okcoker okcoker commented May 6, 2015

To alleviate #5 for now.

@chicoxyzzy
Copy link

👎
as I said here all target browsers could have native Symbol / Reflect. we should just add some notes / caveats about one might need polyfills to use autobind decorator. we need babel to use this anyway. so it's possible that user of this decorator already uses core.js (or even harmony-reflect or other polyfill). also this dependancy should be definitely added to peerDependencies if it will be added though

@andreypopp
Copy link
Owner

Native support for Reflect is almost not existent at the moment. Not sure if we want to require it explicitly though...

@aldendaniels
Copy link
Contributor

👎

What about progressive enhancement?

  1. If Reflect is globally defined, then use it.
  2. If not, then use Object.getOwnPropertyNames() and don't worry about symbols

@andreypopp
Copy link
Owner

@aldendaniels good suggestion, anybody wants to submit a PR?

@domarmstrong
Copy link
Collaborator

Created PR #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants