Handle errors from sharp

andrewstuart · Jul 11, 2023 · 70f6268 · 70f6268
1 parent 2961bc6
commit 70f6268
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 29 deletions.
diff --git a/src/server/utils/create-ssr-html.tsx b/src/server/utils/create-ssr-html.tsx
@@ -30,26 +30,25 @@ export async function createSsrHtml(
   );
 
   if (!appleTouchIcon) {
-    try {
-      appleTouchIcon = site?.site_view.site.icon
-        ? `data:image/png;base64,${await sharp(
-            await fetchIconPng(site.site_view.site.icon)
-          )
-            .resize(180, 180)
-            .extend({
-              bottom: 20,
-              top: 20,
-              left: 20,
-              right: 20,
-              background: "#222222",
-            })
-            .png()
-            .toBuffer()
-            .then(buf => buf.toString("base64"))}`
-        : favIconPngUrl;
-    } catch (err) {
-      console.error(err);
-    }
+    appleTouchIcon = site?.site_view.site.icon
+      ? `data:image/png;base64,${await sharp(
+          await fetchIconPng(site.site_view.site.icon)
+        )
+          .resize(180, 180)
+          .extend({
+            bottom: 20,
+            top: 20,
+            left: 20,
+            right: 20,
+            background: "#222222",
+          })
+          .png()
+          .toBuffer()
+          .then(
+            buf => buf.toString("base64"),
+            err => console.error(err)
+          )}`
+      : favIconPngUrl;
   }
 
   const erudaStr =

diff --git a/src/server/utils/generate-manifest-json.ts b/src/server/utils/generate-manifest-json.ts
@@ -41,15 +41,14 @@ export default async function ({
         ).then(buf => buf.toString("base64"));
 
         if (icon) {
-          try {
-            src = await sharp(icon)
-              .resize(size, size)
-              .png()
-              .toBuffer()
-              .then(buf => buf.toString("base64"));
-          } catch (err) {
-            console.error(err);
-          }
+          src = await sharp(icon)
+            .resize(size, size)
+            .png()
+            .toBuffer()
+            .then(
+              buf => buf.toString("base64"),
+              err => console.error(err)
+            );
         }
 
         return {