addning OS matrix to github action for more robust testing

andrew-bierman · Dec 31, 2023 · 9a7a7f6 · 9a7a7f6
1 parent 2017cff
commit 9a7a7f6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/.github/workflows/node.js.dev.yml b/.github/workflows/node.js.dev.yml
@@ -8,11 +8,12 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x, 20.x, 21.x] # Adjust these versions as per your requirements.
+        os: [ubuntu-latest, windows-latest, macos-latest] # Operating systems
+        node-version: [18.x, 20.x, 21.x] # Node.js versions
 
     steps:
     - name: Checkout Repository

diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -11,14 +11,12 @@ on:
 
 jobs:
   build:
-
-    runs-on: ubuntu-latest
-
+    runs-on: ${{ matrix.os }}
     strategy:
-      fail-fast: false  # This ensures that all versions are tested even if one fails.
+      fail-fast: false
       matrix:
-        node-version: [18.x, 20.x] # Node.js versions to test against. Removed 14.x as it is EOL + Tamagui errors on it.
-        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+        os: [ubuntu-latest, windows-latest, macos-latest] # Operating systems
+        node-version: [18.x, 20.x, 21.x] # Node.js versions
 
     steps:
       - uses: actions/checkout@v3