Skip to content

Commit

Permalink
Merge pull request #793 from andrew-bierman/fix-add-item-modal-close
Browse files Browse the repository at this point in the history
  • Loading branch information
andrew-bierman authored Apr 2, 2024
2 parents 260185b + 1ec7325 commit 145b91b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
4 changes: 4 additions & 0 deletions packages/app/components/pack/AddItemModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,15 @@ export const AddItemModal = ({
},
]}
footerComponent={undefined}
isOpen={isAddItemModalOpen}
onOpen={() => setIsAddItemModalOpen(true)}
onClose={() => setIsAddItemModalOpen(false)}
>
<AddItem
packId={currentPackId}
currentPack={currentPack}
setRefetch={setRefetch}
closeModalHandler={() => setIsAddItemModalOpen(false)}
/>
</BaseModal>
);
Expand Down
5 changes: 4 additions & 1 deletion packages/ui/src/modal/BaseModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export interface BaseModalProps {
triggerComponent?: React.DetailedReactHTMLElement<any, HTMLElement>;
footerComponent: React.DetailedReactHTMLElement<any, HTMLElement>;
isOpen?: Boolean;
onOpen?: () => void;
onClose?: () => void;
showTrigger?: Boolean;
}
Expand All @@ -27,8 +28,9 @@ export const BaseModal = ({
footerComponent,
children,
onClose,
onOpen,
isOpen,
showTrigger = true
showTrigger = true,
}: BaseModalProps) => {
const [isModalOpen, setIsModalOpen] = useState(false);

Expand Down Expand Up @@ -85,6 +87,7 @@ export const BaseModal = ({
open={isModalOpen}
onOpenChange={(open) => {
setIsModalOpen(open);
if (open && onOpen) onOpen();
if (!open && onClose) onClose();
}}
>
Expand Down

0 comments on commit 145b91b

Please sign in to comment.