Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Configurable working directory #36

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

MatteoOnger
Copy link

Congratulations for this repository, just an opinion: in some cases, it might be useful to be able to set the working directory.

Added env var NVCC_4_JUPYTER_WORK_DIR to be able to choose the working dir.
Minor imporv.
Minor improv.
Changing the default working directory.
Set working directory using %config.
Removing useless vars.
Adding comment.
Adding description.
Typo solved.
Removing unused lib.
@cosminc98
Copy link
Collaborator

Hello! Thank you for your contribution! I'm going to have a look in depth at the code hopefully soon. Until then please make sure to run the pre-commit hooks locally to fix the formatting of your changes.

@cosminc98 cosminc98 self-assigned this Jun 23, 2024
@cosminc98
Copy link
Collaborator

cosminc98 commented Jun 23, 2024

You don't have write access to the MatteoOnger/nvcc4jupyter repository, so you cannot push changes to it.

I tried pushing a commit to the fork. It seems like I don't have maintainer rights (to the original nvcc4jupyter repo). @MatteoOnger @andreinechaev One of you must fix the pre-commit hooks.

@andreinechaev
Copy link
Owner

andreinechaev commented Aug 11, 2024

You don't have write access to the MatteoOnger/nvcc4jupyter repository, so you cannot push changes to it.

I tried pushing a commit to the fork. It seems like I don't have maintainer rights (to the original nvcc4jupyter repo). @MatteoOnger @andreinechaev One of you must fix the pre-commit hooks.

Hello everyone, did @MatteoOnger abandon this PR?

@cosminc98
Copy link
Collaborator

cosminc98 commented Aug 17, 2024

It's almost done, but what's left is to fix this change (by moving the "# pylint: disable=import-error" back up)
image

I would actually add it to both of the lines with the pylint error (at the end) to prevent them being moved again in the future.

@MatteoOnger
Copy link
Author

I have moved the line back up, if you prefer to add them elsewhere let me know. And sorry for the late response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants