Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper lib (Async TP) #561

Merged
merged 11 commits into from
Dec 20, 2022
Merged

Paper lib (Async TP) #561

merged 11 commits into from
Dec 20, 2022

Conversation

JT122406
Copy link
Contributor

@JT122406 JT122406 commented Jul 7, 2022

Implements PaperLib Async TP to improve server performance works on all Spigot based server software but performance enhancements are Only on Paper and Paper Forks. Has been tested on 1.8.8-1.18.1

@JT122406 JT122406 temporarily deployed to development July 7, 2022 16:07 Inactive
@JT122406 JT122406 temporarily deployed to development August 17, 2022 20:11 Inactive
@andrei1058
Copy link
Owner

Ok but who asked? I appreciate your interest in my plugin, but when you come with new implementations you need to consider everyone else and officially supported server softwares and explain why we need that lib, what is changing, what are the benefits, what are the risks etc. Give a look at CONTRIBUTING.md and ping me when you are able to provide required information. I do not know what you are doing here and why.

@JT122406
Copy link
Contributor Author

Ok but who asked? I appreciate your interest in my plugin, but when you come with new implementations you need to consider everyone else and officially supported server softwares and explain why we need that lib, what is changing, what are the benefits, what are the risks etc. Give a look at CONTRIBUTING.md and ping me when you are able to provide required information. I do not know what you are doing here and why.

So the reason why is since in bedwars there is a lot of teleporting people back to spawn teleporting to spectator spawn stuff like that and with all that happening large servers with many games happening at once can benefit from having the teleports be off the main thread making the games smoother and tps higher for the servers. I have tested it and have had others test as well and all love the performance benefit. The risks of including this lib are pretty much none as on spigot and not paper it just uses normal teleport and when on paper or paperforks it uses the async library I can do some more things so we don’t need to shade it by adding it to version support and using that class with a paper server and then I could also add a config option to allow it to be disabled by owners who are on paper but up to you

# Conflicts:
#	bedwars-plugin/src/main/java/com/andrei1058/bedwars/listeners/joinhandler/JoinListenerMultiArena.java
@andrei1058 andrei1058 temporarily deployed to development December 20, 2022 17:45 — with GitHub Actions Inactive
@andrei1058 andrei1058 merged commit 67bf6f6 into andrei1058:master Dec 20, 2022
@JT122406 JT122406 deleted the PaperLib branch December 20, 2022 20:02
andrei1058 added a commit that referenced this pull request Jan 22, 2023
* Some PAFBungeecord Fixes (#442)

fix PAFBungeecord adapter

* Register Indonesia Languange on start up (#452)

* fix env var passing

* Enhance levelling system (#448)

* Updated Levelling System

* Fixed if with Java convention

* Change BED_DESTROYED to BED_DESTROY

* workflow update

* Update readme to link to wiki for addons/setups (#462)

* band-aid fix for ConcurrentModificationException on disable (#460)

* [enhancement] Fix Invisibility Potions on 1.8 and some cosmetic changes (#408)

* Make titles smoothly fade out

* What was the point for such long cooldown?

* Fix english grammar error

* Fix Invisibility Potion not working on 1_8_R3

* Revert "What was the point for such long cooldown?"

This reverts commit f66e035.

Co-authored-by: MarcelDutko <[email protected]>

* Implement command for set max build Y (#428)

* TeamEliminatedEvent (#465)

* Update deprecated versions (#495)

* fix arenaGroup list command requiring unnecisary args (#484)

* register forgotten listener

* allow enabling of hunger (#485)

* Reload command in console (#506)

* Make reload command executable by console

* Inline the Player casting

* update #canSee so console sees the command

i find really no need to retest this but whatever

* Remove unused import + fix a typo

* Italian Language Update (#501)

* Fix traps not activating when someone is on island (#546)

* Update stuff (#545)

* Update Repos/Maven Plugins and fix some build warning

* Remove old Gitlab stuff

* 17.0.3 Workflow

* Didn't mean to remove this

* Java 11 Minimum Requirement (#541)

* Fix Players sometimes can't Pickup items (#530)

Fixes #520

* Remove Support for: (#538)

1.9.4 (v1_9_R2)
1.10 - 1.10.2 (v1_10_R1)
1.11 (v1_11_R1)
1.13.1 - 1.13.2 (v1_13_R2)
1.14 - 1.14.2 (v1_14_R1)
1.15 - 1.15.2 (v1_15_R1)
1.16.1 - 1.16.3 (v1_16_R1/2)

* Fix Red not auto-scanning (#519)

* Fix Red not auto-scanning

* Fix Red not auto-scanning

Co-authored-by: Bart <[email protected]>
Co-authored-by: DevSolaris <[email protected]>

* Fix readme for Java 11 (#556)

* Use NMS and Don't call event when player is afk to save resources (#584)

* Update Spanish.java (#523)

* Fix Light Gray (#518)

Co-authored-by: Bart <[email protected]>

* Fixes issues with invsibility potion and armor & bug with inv. shop when click on bottom inv (#590)

* Fix shop interacting through own inventory

* Fix visible armor when drink invisibility potion

* Fix stats placeholder throwing exceptions when a player is unloaded + a small cleanup (#567)

* fixed citizens repo (#609)

* Fixed the nms setSource method in versions: 1_17_R1 and 1_18_R2 (#615)

* Fixed source field's name

* Fixed source field's name

* Remove Spigot Update Checker (no longer use spigotmc) (#616)

* Remove Spigot Update Checker (no longer use spigotmc)

* Updates

* Add the Max in team placeholder to the signs (#594)

* Add the Max in team placeholder to the signs

* Bug fix on server restart

Co-authored-by: Angel <[email protected]>

* Cancel Pickup if player is AFK and remove extra listener (#587)

* Cancel Pickup if player is AFK and remove extra listener

* Forgot

* SidebarLib implementation and 1.19.3 support (#617)

implement sidebar lib, add 1.19.3 support

* Money bug fix (#585)

sync with main thread, clean up threads

* Money fix (#582)

give rewards if greater than zero, do not give rewards for team assist on solo

* Make Armor shop message say equipped (#565)

make armor-shop say equipped and not maxed as that does not make sense for armor

* implement async teleport on paper servers (#561)

implement async teleport on paper servers

* Built in Pop-Up tower (#496)

* prevent generators from spawning on game end, clean inventories and dropped items (#487)

prevent generators from spawning on game end, clean inventories and dropped items

* Built-in heal pool animations (#467)

* Polish translation update (#431)

* fix: could not pass event PlayerJoinEvent

fix NullPointerException at player join when game has no set arena yet

Co-authored-by: J.T. McQuigg <[email protected]>
Co-authored-by: JektDV <[email protected]>
Co-authored-by: Xxyuri2005xX <[email protected]>
Co-authored-by: ajgeiss0702 <[email protected]>
Co-authored-by: Marcelektro <[email protected]>
Co-authored-by: MarcelDutko <[email protected]>
Co-authored-by: Ricardo <[email protected]>
Co-authored-by: iiAhmedYT <[email protected]>
Co-authored-by: Memexurer <[email protected]>
Co-authored-by: IIHERO4 <[email protected]>
Co-authored-by: DevSolaris <[email protected]>
Co-authored-by: Bart <[email protected]>
Co-authored-by: DevSolaris <[email protected]>
Co-authored-by: Danidev819 <[email protected]>
Co-authored-by: Zoiter7 <[email protected]>
Co-authored-by: Doãn Hiệp <[email protected]>
Co-authored-by: PmzHeroV69 <[email protected]>
Co-authored-by: Angelillo15 <[email protected]>
Co-authored-by: Angel <[email protected]>
Co-authored-by: Seriously Not Beluga <[email protected]>
Co-authored-by: jonathan-up <[email protected]>
Co-authored-by: MrCeasar <[email protected]>
andrei1058 added a commit that referenced this pull request Jan 22, 2023
* Some PAFBungeecord Fixes (#442)

fix PAFBungeecord adapter

* Register Indonesia Languange on start up (#452)

* fix env var passing

* Enhance levelling system (#448)

* Updated Levelling System

* Fixed if with Java convention

* Change BED_DESTROYED to BED_DESTROY

* pliz

* oh gosh

* workflow update

* Update readme to link to wiki for addons/setups (#462)

* band-aid fix for ConcurrentModificationException on disable (#460)

* [enhancement] Fix Invisibility Potions on 1.8 and some cosmetic changes (#408)

* Make titles smoothly fade out

* What was the point for such long cooldown?

* Fix english grammar error

* Fix Invisibility Potion not working on 1_8_R3

* Revert "What was the point for such long cooldown?"

This reverts commit f66e035.

Co-authored-by: MarcelDutko <[email protected]>

* Implement command for set max build Y (#428)

* TeamEliminatedEvent (#465)

* Update deprecated versions (#495)

* fix arenaGroup list command requiring unnecisary args (#484)

* register forgotten listener

* allow enabling of hunger (#485)

* Reload command in console (#506)

* Make reload command executable by console

* Inline the Player casting

* update #canSee so console sees the command

i find really no need to retest this but whatever

* Remove unused import + fix a typo

* Italian Language Update (#501)

* Fix traps not activating when someone is on island (#546)

* Update stuff (#545)

* Update Repos/Maven Plugins and fix some build warning

* Remove old Gitlab stuff

* 17.0.3 Workflow

* Didn't mean to remove this

* Java 11 Minimum Requirement (#541)

* Fix Players sometimes can't Pickup items (#530)

Fixes #520

* Remove Support for: (#538)

1.9.4 (v1_9_R2)
1.10 - 1.10.2 (v1_10_R1)
1.11 (v1_11_R1)
1.13.1 - 1.13.2 (v1_13_R2)
1.14 - 1.14.2 (v1_14_R1)
1.15 - 1.15.2 (v1_15_R1)
1.16.1 - 1.16.3 (v1_16_R1/2)

* Fix Red not auto-scanning (#519)

* Fix Red not auto-scanning

* Fix Red not auto-scanning

Co-authored-by: Bart <[email protected]>
Co-authored-by: DevSolaris <[email protected]>

* Fix readme for Java 11 (#556)

* Use NMS and Don't call event when player is afk to save resources (#584)

* Update Spanish.java (#523)

* Fix Light Gray (#518)

Co-authored-by: Bart <[email protected]>

* Fixes issues with invsibility potion and armor & bug with inv. shop when click on bottom inv (#590)

* Fix shop interacting through own inventory

* Fix visible armor when drink invisibility potion

* Fix stats placeholder throwing exceptions when a player is unloaded + a small cleanup (#567)

* fixed citizens repo (#609)

* Fixed the nms setSource method in versions: 1_17_R1 and 1_18_R2 (#615)

* Fixed source field's name

* Fixed source field's name

* Remove Spigot Update Checker (no longer use spigotmc) (#616)

* Remove Spigot Update Checker (no longer use spigotmc)

* Updates

* Add the Max in team placeholder to the signs (#594)

* Add the Max in team placeholder to the signs

* Bug fix on server restart

Co-authored-by: Angel <[email protected]>

* Cancel Pickup if player is AFK and remove extra listener (#587)

* Cancel Pickup if player is AFK and remove extra listener

* Forgot

* SidebarLib implementation and 1.19.3 support (#617)

implement sidebar lib, add 1.19.3 support

* Money bug fix (#585)

sync with main thread, clean up threads

* Money fix (#582)

give rewards if greater than zero, do not give rewards for team assist on solo

* Make Armor shop message say equipped (#565)

make armor-shop say equipped and not maxed as that does not make sense for armor

* implement async teleport on paper servers (#561)

implement async teleport on paper servers

* Built in Pop-Up tower (#496)

* prevent generators from spawning on game end, clean inventories and dropped items (#487)

prevent generators from spawning on game end, clean inventories and dropped items

* Built-in heal pool animations (#467)

* Polish translation update (#431)

* fix: could not pass event PlayerJoinEvent

fix NullPointerException at player join when game has no set arena yet

* fix spigot support #642 (#643)

Co-authored-by: J.T. McQuigg <[email protected]>
Co-authored-by: JektDV <[email protected]>
Co-authored-by: Xxyuri2005xX <[email protected]>
Co-authored-by: ajgeiss0702 <[email protected]>
Co-authored-by: Marcelektro <[email protected]>
Co-authored-by: MarcelDutko <[email protected]>
Co-authored-by: Ricardo <[email protected]>
Co-authored-by: iiAhmedYT <[email protected]>
Co-authored-by: Memexurer <[email protected]>
Co-authored-by: IIHERO4 <[email protected]>
Co-authored-by: DevSolaris <[email protected]>
Co-authored-by: Bart <[email protected]>
Co-authored-by: DevSolaris <[email protected]>
Co-authored-by: Danidev819 <[email protected]>
Co-authored-by: Zoiter7 <[email protected]>
Co-authored-by: Doãn Hiệp <[email protected]>
Co-authored-by: PmzHeroV69 <[email protected]>
Co-authored-by: Angelillo15 <[email protected]>
Co-authored-by: Angel <[email protected]>
Co-authored-by: Seriously Not Beluga <[email protected]>
Co-authored-by: jonathan-up <[email protected]>
Co-authored-by: MrCeasar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants