Do not remove death message unless player is in a game #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirod12
approved these changes
Jan 19, 2022
ajgeiss0702
approved these changes
Jan 19, 2022
|
remove the message if the player dies in lobby world as well |
andrei1058
added
the
requires-changes
|
Sure, I'll change that. |
|
Sorry for the delay. Should I also add a check for MULTIARENA for the lobby? Or is this fine? |
|
(BedWars.getLobbyWorld().equals(e.getEntity().getWorld().getName()) and MULTIARENA) otherwise if you switch to SHARED it will keep disabling kill message in lobby world since it is still in config.yml |
|
Any blockers on this? Or is it good to go? |
Cubixmeister
pushed a commit
to kwadratowa/BedWars1058
that referenced
this pull request
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just changes the PlayerDeathEvent listener so that it doesn't remove the death message unless the player is actually in a game.