Include <chrono>
for high_resolution_clock
#88
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I work on Microsoft Visual C++, where we regularly build popular open-source projects, including yours, with development builds of our compiler and libraries to detect and prevent shipping regressions that would affect you. This also allows us to provide advance notice of breaking changes, which is the case here.
I just merged microsoft/STL#5105, which revealed a conformance issue in cppcoro.
Compiler error with this STL change:
Affected code:
cppcoro/test/cancellation_token_tests.cpp
Line 294 in a4ef652
This was assuming that including
<thread>
makes thechrono::high_resolution_clock
type available, which is not guaranteed by the Standard. You must explicitly include<chrono>
.