Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

Feature: print QR options #371

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Feature: print QR options #371

merged 4 commits into from
Jan 25, 2022

Conversation

andi34
Copy link
Owner

@andi34 andi34 commented Jan 24, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

  • New feature

What changes did you make? (Give an overview)

New settings while printing QR-Code onto the image:

  • QR size adjustable
  • QR offset adjustable
  • QR position adjustable
  • QR error correction adjustable

By default place the QR-Code on the bottom right corner, use an small QR-Code with an small offset of 10px to the edges.

Is there anything you'd like reviewers to focus on?

Screenshot_20220125-232740

Screenshot_20220125-232752

Screenshot_20220125-232758

Copy link
Owner Author

@andi34 andi34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@up-87 what do you think?

New settings from print:
- QR size adjustable
- QR offset adjustable
- QR position adjustable

By default place the QR-Code on the bottom right corner,
use an small QR-Code with an small offset of 10px to the edges.

Change-Id: I28baec6a6d0903cb47e3bf4145a751510740d3c0
Change-Id: Iefa6f4666eaa337866ea0a6be8b8c96b6bade8eb
@andi34 andi34 force-pushed the feature/qr-options branch from e9d1330 to c56d4d2 Compare January 25, 2022 20:21
Lower default used error correction level from H to M.

Information:
https: //www.qrcode.com/en/about/error_correction.html
https: //blog.qrstuff.com/2011/12/14/qr-code-error-correction
Change-Id: I4849a340caeb4dfbc5933a90de4585ed8d932961
Change-Id: Iddde9a9258b56cb017ae247d22a65aec5602cc74
@andi34 andi34 force-pushed the feature/qr-options branch from c56d4d2 to f3baaf9 Compare January 25, 2022 20:27
@andi34 andi34 merged commit 4f7fc32 into dev Jan 25, 2022
@andi34 andi34 deleted the feature/qr-options branch January 25, 2022 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants