Fix risky uses of __anext__()
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necessarily iterators
mikenerone
force-pushed
the
mikenerone/fix-ensure-use-of-iterators
branch
from
408988f to
428e033
Compare
|
Marvellous! A joy to review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
__anext__()on an async iterable is dangerous, because not all iterables act as their own iterators, so may not have that method. These changes ensure that those calls explicitly get an iterator first (by calling__aiter__()).Note:
__aiter__()is called implicitly inasync forconstructs, so they don't have this risk.