Allow specific versions of formats to be specified #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Feb 6, 2023
Comment on lines
-33
to
+34
| cmd.Flags().StringArrayVarP(&o.Output, "output", "o", FormatAliases(table.ID), | ||
| fmt.Sprintf("report output format, options=%v", FormatAliases(syft.FormatIDs()...))) | ||
| cmd.Flags().StringArrayVarP(&o.Output, "output", "o", []string{string(table.ID)}, | ||
| fmt.Sprintf("report output format, options=%v", formats.AllIDs())) |
There was a problem hiding this comment.
Lingering question: should this function (FormatAliases) still exist to customize the format output to the client?
There was a problem hiding this comment.
as long as the cli package has all existing cases covered I think it's alright to remove this
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
reviewed
Feb 7, 2023
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
reviewed
Feb 7, 2023
wagoodman
reviewed
Feb 7, 2023
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
reviewed
Feb 7, 2023
wagoodman
reviewed
Feb 7, 2023
Signed-off-by: Keith Zantow <[email protected]>
This was referenced Feb 9, 2023
This was referenced Feb 17, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for including a version number along with formats, for example:
[email protected]orsyft@6.Fixes #1519