Add protobuf FPs to default ignore list #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Luhring <[email protected]>
spiffcs
approved these changes
Jan 20, 2023
|
Thanks @luhring! I think this is pretty straightforward. If this list keeps getting bigger we can revisit it. Before we merge I'll wait for others from the open source team to comment on if we can add a commit to reduce the UI confusion here |
kzantow
approved these changes
Jan 20, 2023
spiffcs
added a commit
to willyw0nka/grype
that referenced
this pull request
Jan 24, 2023
* main: (56 commits) fix: always include severity in cyclonedx output (anchore#1067) Update Syft to v0.68.0 (anchore#1064) Add protobuf FPs to default ignore list (anchore#1062) chore: update Syft to v0.66.2 (anchore#1060) Update grype bootstrap tools to latest versions. (anchore#1055) feat: allow grype db diff to specify local db directories (anchore#1058) chore: claim artifacthub package ownership from developer-guy (anchore#661) chore: add github token to quality tests (anchore#1056) chore: update yardstick to diagnose intermittent failures (anchore#1054) Update grype bootstrap tools to latest versions. (anchore#1048) fix: sort vulnerability results (anchore#1052) Adding internal/file/hasher test cases (anchore#1049) fix: orient by cve merging (anchore#1046) Update Syft to v0.64.0 (anchore#1047) fix: update removing results based on ownership-by-file-overlap (anchore#1045) feat: swap custom cyclone-dx model for cyclone-dx library (anchore#1038) chore: add GitLab Community Edition image to quality gate (anchore#1035) Update Syft to v0.63.0 (anchore#1037) fix: Exclude binary packages that have overlap by file ownership relationship (anchore#1024) docs: update quality gate docs (anchore#1032) ...
This was referenced Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #558
Let me know if there's a better way to cancel these out in the code. I saw this method used for some log4j FPs so I continued that approach here.
One unfortunate drawback to this approach is the UI becomes a bit confusing:
"2 vulnerabilities", and then "no vulnerabilities". Curious if anyone has thoughts to make this more straightforward.