Removing policy engine feed sync cycle timers (now on data syncer) #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
policy engine feed sync cycle timers are no longer used. Signed-off-by: Lester Wade <[email protected]>
|
Looks like removing stuff needs a bump in the chart version? |
removing the parameters from readme.md Signed-off-by: Lester Wade <[email protected]>
lwade
changed the title
asomya
reviewed
Mar 5, 2025
Signed-off-by: Lester Wade <[email protected]>
Signed-off-by: Lester Wade <[email protected]>
leaving spaces as I'm assuming this might be a convention to show where lines have been pulled Signed-off-by: Lester Wade <[email protected]>
minor patch bump for removal of these bits Signed-off-by: Lester Wade <[email protected]>
add to deprecated Signed-off-by: Lester Wade <[email protected]>
Signed-off-by: Lester Wade <[email protected]>
bot190
reviewed
Mar 6, 2025
PUT IT BACK!!! ARGGGH Signed-off-by: Lester Wade <[email protected]>
Signed-off-by: Brady Todhunter <[email protected]>
Btodhunter
force-pushed
the
lwade/remove-policy-cycle-timers
branch
from
a8f0272 to
175c85a
Compare
Signed-off-by: Brady Todhunter <[email protected]>
Btodhunter
force-pushed
the
lwade/remove-policy-cycle-timers
branch
from
175c85a to
f182ac6
Compare
|
LGTM! Thanks for the update @lwade I reverted all the changes to mappings.py because that file is specifically for the values conversion script that is only used for migrating from the anchore-engine chart to the enterprise chart. It needs to have the same values as the Enterprise values file referenced in the migration docs. I also updated the config snapshots for the Helm unit tests to get them passing. |
Btodhunter
approved these changes
Mar 6, 2025
|
Thank you @Btodhunter ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
policy engine feed sync cycle timers are no longer used.