-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor CI workflow to move linter to its own flow #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6703f89
to
a77ce08
Compare
Signed-off-by: Zach Hill <[email protected]>
a77ce08
to
fa5876a
Compare
Btodhunter
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Btodhunter
pushed a commit
that referenced
this pull request
Sep 3, 2024
…to facilitate better SSO debugging (#243) Signed-off-by: Zach Hill <[email protected]>
HN23
pushed a commit
that referenced
this pull request
Sep 30, 2024
…to facilitate better SSO debugging (#243) Signed-off-by: Zach Hill <[email protected]>
HN23
pushed a commit
that referenced
this pull request
Sep 30, 2024
…to facilitate better SSO debugging (#243) Signed-off-by: Zach Hill <[email protected]> Signed-off-by: Hung Nguyen <[email protected]>
HN23
added a commit
that referenced
this pull request
Sep 30, 2024
…to facilitate better SSO debugging (#243) update readme adding tests update tests to add required values move required check into configmap Signed-off-by: Hung Nguyen <[email protected]> Signed-off-by: Zach Hill <[email protected]>
Btodhunter
pushed a commit
that referenced
this pull request
Oct 1, 2024
* fix: adds log_saml_assertions to the default config with value=false to facilitate better SSO debugging (#243) Signed-off-by: Zach Hill <[email protected]> * fix: adds log_saml_assertions to the default config with value=false to facilitate better SSO debugging (#243) Signed-off-by: Zach Hill <[email protected]> Signed-off-by: Hung Nguyen <[email protected]> * feat: chart for enterprise v5.10.0 helm chart for enterprise v5.10.0 with hosted feeds Signed-off-by: Arvind Somya <[email protected]> Signed-off-by: Hung Nguyen <[email protected]> * Adding test for dataSyncer resource (#245) * Added test for dataSyncer resource; updated common_helpers_test.yaml with the new dataSyncer test; updated .gitignore for vscode use Signed-off-by: Jesse Tamburino <[email protected]> * Updated tests and added missing tests Signed-off-by: Jesse Tamburino <[email protected]> * Bumped the version of the chart Signed-off-by: Jesse Tamburino <[email protected]> --------- Signed-off-by: Jesse Tamburino <[email protected]> Co-authored-by: Jesse Tamburino <[email protected]> Signed-off-by: Hung Nguyen <[email protected]> * fix readme removing unused code make osaa_config in line with default config license secret creation not dependent on useExistingSecrets bumping chart version for dev-sync to prod bump feeds app version to correct version Signed-off-by: Hung Nguyen <[email protected]> * fix: adds log_saml_assertions to the default config with value=false to facilitate better SSO debugging (#243) update readme adding tests update tests to add required values move required check into configmap Signed-off-by: Hung Nguyen <[email protected]> Signed-off-by: Zach Hill <[email protected]> --------- Signed-off-by: Zach Hill <[email protected]> Signed-off-by: Hung Nguyen <[email protected]> Signed-off-by: Arvind Somya <[email protected]> Signed-off-by: Jesse Tamburino <[email protected]> Co-authored-by: Zach Hill <[email protected]> Co-authored-by: Arvind Somya <[email protected]> Co-authored-by: Jesse <[email protected]> Co-authored-by: Jesse Tamburino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new linter workflow and removes that step from the test workflow.
Should make matrix tests easier and linting issues faster to resolve.
Signed-off-by: Zach Hill [email protected]