Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor CI workflow to move linter to its own flow #243

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

zhill
Copy link
Member

@zhill zhill commented Jan 23, 2023

Adds new linter workflow and removes that step from the test workflow.
Should make matrix tests easier and linting issues faster to resolve.

Signed-off-by: Zach Hill [email protected]

@zhill zhill requested a review from a team as a code owner January 23, 2023 23:54
Copy link
Member

@Btodhunter Btodhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Btodhunter Btodhunter merged commit 9973ad7 into main Jan 24, 2023
@Btodhunter Btodhunter deleted the separate_linter branch January 24, 2023 01:20
Btodhunter pushed a commit that referenced this pull request Sep 3, 2024
…to facilitate better SSO debugging (#243)

Signed-off-by: Zach Hill <[email protected]>
HN23 pushed a commit that referenced this pull request Sep 30, 2024
…to facilitate better SSO debugging (#243)

Signed-off-by: Zach Hill <[email protected]>
HN23 pushed a commit that referenced this pull request Sep 30, 2024
…to facilitate better SSO debugging (#243)

Signed-off-by: Zach Hill <[email protected]>
Signed-off-by: Hung Nguyen <[email protected]>
HN23 added a commit that referenced this pull request Sep 30, 2024
…to facilitate better SSO debugging (#243)

update readme
adding tests
update tests to add required values
move required check into configmap

Signed-off-by: Hung Nguyen <[email protected]>
Signed-off-by: Zach Hill <[email protected]>
Btodhunter pushed a commit that referenced this pull request Oct 1, 2024
* fix: adds log_saml_assertions to the default config with value=false to facilitate better SSO debugging (#243)

Signed-off-by: Zach Hill <[email protected]>

* fix: adds log_saml_assertions to the default config with value=false to facilitate better SSO debugging (#243)

Signed-off-by: Zach Hill <[email protected]>
Signed-off-by: Hung Nguyen <[email protected]>

* feat: chart for enterprise v5.10.0

helm chart for enterprise v5.10.0 with hosted feeds

Signed-off-by: Arvind Somya <[email protected]>
Signed-off-by: Hung Nguyen <[email protected]>

* Adding test for dataSyncer resource (#245)

* Added test for dataSyncer resource; updated common_helpers_test.yaml with the new dataSyncer test; updated .gitignore for vscode use

Signed-off-by: Jesse Tamburino <[email protected]>

* Updated tests and added missing tests

Signed-off-by: Jesse Tamburino <[email protected]>

* Bumped the version of the chart

Signed-off-by: Jesse Tamburino <[email protected]>

---------

Signed-off-by: Jesse Tamburino <[email protected]>
Co-authored-by: Jesse Tamburino <[email protected]>
Signed-off-by: Hung Nguyen <[email protected]>

* fix readme
removing unused code
make osaa_config in line with default config
license secret creation not dependent on useExistingSecrets
bumping chart version for dev-sync to prod
bump feeds app version to correct version

Signed-off-by: Hung Nguyen <[email protected]>

* fix: adds log_saml_assertions to the default config with value=false to facilitate better SSO debugging (#243)
update readme
adding tests
update tests to add required values
move required check into configmap

Signed-off-by: Hung Nguyen <[email protected]>
Signed-off-by: Zach Hill <[email protected]>

---------

Signed-off-by: Zach Hill <[email protected]>
Signed-off-by: Hung Nguyen <[email protected]>
Signed-off-by: Arvind Somya <[email protected]>
Signed-off-by: Jesse Tamburino <[email protected]>
Co-authored-by: Zach Hill <[email protected]>
Co-authored-by: Arvind Somya <[email protected]>
Co-authored-by: Jesse <[email protected]>
Co-authored-by: Jesse Tamburino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants