Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typeahead): use optionGroup instead of options #67

Merged
merged 4 commits into from
Aug 13, 2018
Merged

Conversation

ritz078
Copy link
Contributor

@ritz078 ritz078 commented Aug 13, 2018

No description provided.

@vercel
Copy link

vercel bot commented Aug 13, 2018

This pull request is automatically deployed with Now.

To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #67 into master will increase coverage by 8.81%.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   66.11%   74.93%   +8.81%     
==========================================
  Files          63       62       -1     
  Lines         850      794      -56     
  Branches      145      130      -15     
==========================================
+ Hits          562      595      +33     
+ Misses        276      184      -92     
- Partials       12       15       +3
Impacted Files Coverage Δ
src/components/index.ts 100% <ø> (ø) ⬆️
src/components/OptionGroup.tsx 58.97% <0%> (+1.07%) ⬆️
src/components/Select.tsx 100% <100%> (+59.09%) ⬆️
src/components/TypeAhead.tsx 32.14% <20%> (+10.71%) ⬆️
src/components/OutsideClick.tsx 78.94% <0%> (+21.05%) ⬆️
src/components/DropDown.tsx 87.5% <0%> (+43.75%) ⬆️
src/components/Input.tsx 80.55% <0%> (+61.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d09f96...2d0e2ca. Read the comment docs.

@ritz078 ritz078 merged commit 29aeb2c into master Aug 13, 2018
@ritz078 ritz078 deleted the use-option branch August 13, 2018 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant