add button element props #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritz078
approved these changes
Apr 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 82.24% 82.24%
=======================================
Files 75 75
Lines 1098 1098
Branches 201 201
=======================================
Hits 903 903
Misses 174 174
Partials 21 21
Continue to review full report at Codecov.
|
azizhk
reviewed
Apr 12, 2019
| @@ -15,6 +15,7 @@ export interface ButtonProps { | |||
| showRipple?: boolean; | |||
| loading?: boolean; | |||
| filled?: boolean; | |||
| buttonProps?: React.ButtonHTMLAttributes<HTMLButtonElement>; | |||
There was a problem hiding this comment.
Don't take in extra object prop.
Allow them to be passed in props level.
There was a problem hiding this comment.
But it will cause conflicts, for e.g., type of HTMLButtonElement means and accepts value other than what type of Pebble's Button component.
|
I thought I had submitted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.