Dropdown: location aware #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 82.24% 82.29% +0.05%
==========================================
Files 75 75
Lines 1098 1107 +9
Branches 201 205 +4
==========================================
+ Hits 903 911 +8
Misses 174 174
- Partials 21 22 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 82.24% 82.12% -0.12%
==========================================
Files 75 75
Lines 1098 1119 +21
Branches 201 212 +11
==========================================
+ Hits 903 919 +16
- Misses 174 178 +4
- Partials 21 22 +1
Continue to review full report at Codecov.
|
ritz078
reviewed
Apr 12, 2019
| onFocus={[Function]} | ||
| > | ||
| <input | ||
| aria-label="" |
There was a problem hiding this comment.
what's the point of having an empty label?
|
There's seems to be a difference in design. |
ritz078
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.