Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CommonJS Distribution #214

Merged
merged 7 commits into from
Mar 14, 2019
Merged

Fix CommonJS Distribution #214

merged 7 commits into from
Mar 14, 2019

Conversation

azizhk
Copy link
Contributor

@azizhk azizhk commented Mar 12, 2019

next-transpile-modules has some issues with next 8 and so need to distribute commonjs bundle correctly. (And as how it should be.)

But for some reason UMD bundle does not get built if I make any changes to CJS bundle.

@azizhk azizhk requested a review from ritz078 March 12, 2019 13:42
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files          75       75           
  Lines        1092     1092           
  Branches      198      198           
=======================================
  Hits          897      897           
  Misses        174      174           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ecdf4...b7d024e. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files          75       75           
  Lines        1092     1092           
  Branches      198      198           
=======================================
  Hits          897      897           
  Misses        174      174           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ecdf4...2af35ed. Read the comment docs.

@ritz078
Copy link
Contributor

ritz078 commented Mar 14, 2019

Does webpack support esnext by default?

@azizhk
Copy link
Contributor Author

azizhk commented Mar 14, 2019

Webpack supports module by default but does not transpile it.
What we were publishing was esnext only.
I'll add another build for module with transpilation done.

@ritz078 ritz078 merged commit 85caf81 into master Mar 14, 2019
@azizhk azizhk deleted the fix_cjs_dist branch March 14, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants