Tidy up typings a bit #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
azizhk
commented
Oct 29, 2018
ritz078
approved these changes
Oct 29, 2018
|
Tests and build are failing. |
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 74.2% 75.26% +1.06%
==========================================
Files 71 71
Lines 845 857 +12
Branches 163 172 +9
==========================================
+ Hits 627 645 +18
+ Misses 202 194 -8
- Partials 16 18 +2
Continue to review full report at Codecov.
|
ritz078
approved these changes
Nov 1, 2018
azizhk
commented
Dec 21, 2018
| <Slider | ||
| onValuesUpdated={({ values }) => store.set({ value: values })} | ||
| onValuesUpdated={({ min, max }) => store.set({ value: [min, max] })} |
There was a problem hiding this comment.
This was wrong.
Fixed in https://github.com/ritz078/pebble/pull/167/files#diff-221f70a125dc1788290163c421ba27a5R20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only 412 lines added. 1800 lines in yarn.lock due to integrity check.