Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Outside click on touchstart event #127

Merged
merged 1 commit into from
Oct 23, 2018
Merged

remove Outside click on touchstart event #127

merged 1 commit into from
Oct 23, 2018

Conversation

l3satwik
Copy link
Contributor

No description provided.

@l3satwik l3satwik requested review from azizhk and ritz078 October 22, 2018 12:31
@vercel
Copy link

vercel bot commented Oct 22, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Oct 22, 2018 •
edited
Loading

Codecov Report

Merging #127 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   74.17%   74.13%   -0.04%     
==========================================
  Files          69       69              
  Lines         817      812       -5     
  Branches      157      157              
==========================================
- Hits          606      602       -4     
+ Misses        196      195       -1     
  Partials       15       15
Impacted Files Coverage Δ
src/components/OutsideClick.tsx 76.47% <ø> (-2.48%) ⬇️
src/components/TypeAhead.tsx 83.87% <100%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f7e5f...b530adb. Read the comment docs.

l3satwik
l3satwik commented Oct 22, 2018
View reviewed changes
src/components/TypeAhead.tsx
@@ -8,16 +8,12 @@ import OutsideClick from "./OutsideClick";
import OptionGroupRadio from "./OptionGroupRadio";

class TypeAhead extends React.PureComponent<TypeaheadProps, TypeaheadState> {
typeaheadInputRef: React.RefObject<HTMLInputElement> = React.createRef();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undid the hack!

@ritz078 ritz078 merged commit 9ff5bd2 into master Oct 23, 2018
@ritz078 ritz078 deleted the dropdown-scroll branch October 23, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azizhk azizhk azizhk approved these changes

@ritz078 ritz078 ritz078 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l3satwik @azizhk @ritz078