Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onApply & onClear are optional for multiselect #109

Merged
merged 4 commits into from
Oct 12, 2018
Merged

Conversation

l3satwik
Copy link
Contributor

No description provided.

@l3satwik l3satwik requested a review from azizhk October 11, 2018 12:56
@vercel
Copy link

vercel bot commented Oct 11, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@l3satwik l3satwik requested a review from ritz078 October 11, 2018 12:56
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #109 into master will increase coverage by 0.03%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage      74%   74.04%   +0.03%     
==========================================
  Files          68       68              
  Lines         804      809       +5     
  Branches      156      157       +1     
==========================================
+ Hits          595      599       +4     
  Misses        195      195              
- Partials       14       15       +1
Impacted Files Coverage Δ
src/components/Select.tsx 100% <100%> (ø) ⬆️
src/components/OptionGroupCheckBox.tsx 92.3% <75%> (-7.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a0b76e...5a1d9ba. Read the comment docs.

) => void;
onClear: () => void;
) => void | undefined;
onClear: () => void | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onClear?

@ritz078
Copy link
Contributor

ritz078 commented Oct 11, 2018

@l3satwik tests failing

@ritz078 ritz078 merged commit 25a3aee into master Oct 12, 2018
@azizhk azizhk deleted the select-changes branch October 30, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants