Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Phone Number Input #107

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Fix Phone Number Input #107

merged 2 commits into from
Oct 10, 2018

Conversation

azizhk
Copy link
Contributor

@azizhk azizhk commented Oct 9, 2018

No description provided.

@vercel
Copy link

vercel bot commented Oct 9, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@azizhk azizhk requested a review from ritz078 October 9, 2018 14:58
@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   72.62%   72.62%           
=======================================
  Files          67       67           
  Lines         800      800           
  Branches      153      154    +1     
=======================================
  Hits          581      581           
  Misses        205      205           
  Partials       14       14
Impacted Files Coverage Δ
src/components/PhoneNumberInput.tsx 28.57% <25%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa8914...6ffa59d. Read the comment docs.

@ritz078
Copy link
Contributor

ritz078 commented Oct 10, 2018

You want to write tests ?

@azizhk
Copy link
Contributor Author

azizhk commented Oct 10, 2018

Yes writing, will give in next PR today. Merge this as @dxtr026 needs it.

@ritz078 ritz078 merged commit 28f04d9 into master Oct 10, 2018
@ritz078 ritz078 deleted the fix_phonenumber branch October 10, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants