Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style script fix platform dependent path separator #1889

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Style script fix platform dependent path separator #1889

wants to merge 1 commit into from

Conversation

andrei47w
Copy link
Contributor

This should fix the style generation script on windows for users.
We did not encounter this issue since we are using MSYS2 to build on windows.

@andrei47w
Copy link
Contributor Author

This is a complete fix for #1819
We've decided that this is an important fix since users may be using different environments to build Scopy.
Let me know if this works for you @JJuanill @gvanem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisuciu adisuciu Awaiting requested review from adisuciu

@AlexandraTrifan AlexandraTrifan Awaiting requested review from AlexandraTrifan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrei47w