Add improvements to iio-widget #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Andrei-Fabian-Pop
commented
Apr 9, 2024
•
Andrei-Fabian-Pop
commented
- Change the spinbox used in the range gui strategy
- Add new methods for reading the timestamp and status of the last operation
- Add aboutToWrite signal to DataStrategyInterface that returns the old and new value of a write operation
- Add displayedNewData signal to GuiStrategyInterface for signaling when the result of an operation is finished
- Rename AttrUiStrategyInterface to GuiStrategyInterface
Andrei-Fabian-Pop
requested review from
adisuciu,
AlexandraTrifan and
andreidanila1
Andrei-Fabian-Pop
force-pushed
the
dev_iiowidgets_improve
branch
5 times, most recently
from
a2081d7 to
ddfd89e
Compare
adisuciu
approved these changes
Apr 16, 2024
andreidanila1
approved these changes
Apr 17, 2024
Andrei-Fabian-Pop
force-pushed
the
dev_iiowidgets_improve
branch
from
a9e7dba to
6671e60
Compare
AlexandraTrifan
approved these changes
Apr 19, 2024
Andrei-Fabian-Pop
force-pushed
the
dev_iiowidgets_improve
branch
from
f9748e8 to
5ea6a7e
Compare
TitleSpinBox is a class that contains a QSpinBox for displaying values, a QLabel for a title and 2 QPushButtons that for increasing/decreasing the values of said spinbox. The iio-widgets responsible with displaying range values are modified in this commit to use this class. Signed-off-by: Andrei-Fabian-Pop <[email protected]> # Conflicts: # gui/include/gui/stylehelper.h # gui/src/stylehelper.cpp
…tate Signed-off-by: Andrei-Fabian-Pop <[email protected]>
The aboutToWrite signal from DataStrategyInterface will be emitted before any write operation and will contain the old data (aka the data from before the write op) and the new data that will be written Signed-off-by: Andrei-Fabian-Pop <[email protected]>
displayedNewData signal is declared in the gui strategy of an iio-widget and is meant to singnal that the ui successfully received the data programmatically and displayed it. Signed-off-by: Andrei-Fabian-Pop <[email protected]>
…uiStrategyInterface Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
…nd more information about the operation Signed-off-by: Andrei-Fabian-Pop <[email protected]>
…y" state Signed-off-by: Andrei-Fabian-Pop <[email protected]>
The emitStatus signal should be emitted only after the members that retain the data are refreshed. Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Andrei-Fabian-Pop
force-pushed
the
dev_iiowidgets_improve
branch
from
40a6845 to
62da555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.