datamonitor: plot Y axis autoscaler only when is running

Signed-off-by: Ionut Muthi <[email protected]>
analogdevicesinc · May 7, 2024 · cd87b68 · cd87b68
1 parent a2bb01b
commit cd87b68
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/plugins/datamonitorPlugin/include/datamonitorplugin/timemanager.hpp b/plugins/datamonitorPlugin/include/datamonitorplugin/timemanager.hpp
@@ -35,6 +35,7 @@ class TimeManager : public QObject
 
 Q_SIGNALS:
 	void timeout();
+	void toggleRunning(bool toggled);
 
 private:
 	static TimeManager *pinstance_;

diff --git a/plugins/datamonitorPlugin/src/menus/datamonitorsettings.cpp b/plugins/datamonitorPlugin/src/menus/datamonitorsettings.cpp
@@ -5,7 +5,6 @@
 #include <QDebug>
 #include <QLineEdit>
 #include <QScrollArea>
-#include <QTimer>
 #include <datamonitorstylehelper.hpp>
 #include <datamonitorutils.hpp>
 #include <menucollapsesection.h>
@@ -16,6 +15,7 @@
 #include <mousewheelwidgetguard.h>
 #include <plotautoscaler.h>
 #include <plotchannel.h>
+#include <timemanager.hpp>
 
 using namespace scopy;
 using namespace datamonitor;
@@ -119,6 +119,7 @@ QWidget *DataMonitorSettings::generateYAxisSettings(QWidget *parent)
 	plotAutoscaler->setTolerance(10);
 
 	MenuOnOffSwitch *autoscale = new MenuOnOffSwitch(tr("AUTOSCALE"), yAxisSection, false);
+	autoscale->onOffswitch()->setChecked(true);
 
 	connect(autoscale->onOffswitch(), &QAbstractButton::toggled, this, [=, this](bool toggled) {
 		plotYAxisController->setEnabled(!toggled);
@@ -129,7 +130,17 @@ QWidget *DataMonitorSettings::generateYAxisSettings(QWidget *parent)
 		}
 	});
 
-	autoscale->onOffswitch()->setChecked(true);
+	auto &&timeTracker = TimeManager::GetInstance();
+
+	connect(timeTracker, &TimeManager::toggleRunning, this, [=, this](bool toggled){
+		if (toggled) {
+			if (autoscale->onOffswitch()->isChecked()) {
+				plotAutoscaler->start();
+			}
+		} else {
+			plotAutoscaler->stop();
+		}
+	});
 
 	connect(plotAutoscaler, &gui::PlotAutoscaler::newMin, m_plot, &MonitorPlot::updateYAxisIntervalMin);
 	connect(plotAutoscaler, &gui::PlotAutoscaler::newMax, m_plot, &MonitorPlot::updateYAxisIntervalMax);

diff --git a/plugins/datamonitorPlugin/src/timemanager.cpp b/plugins/datamonitorPlugin/src/timemanager.cpp
@@ -52,6 +52,10 @@ void TimeManager::setTimerInterval(double interval) { m_timer->setInterval(inter
 
 bool TimeManager::isRunning() const { return m_isRunning; }
 
-void TimeManager::setIsRunning(bool newIsRunning) { m_isRunning = newIsRunning; }
+void TimeManager::setIsRunning(bool newIsRunning)
+{
+	m_isRunning = newIsRunning;
+	Q_EMIT toggleRunning(newIsRunning);
+}
 
 QDateTime TimeManager::lastReadValue() const { return m_lastReadValue; }